Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 82 expand compatibility to general hdf files #281

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Dec 31, 2024

GitHub Issue: #82

Description

This change enables comparisons of HDF5 files. It has been tested across a variety of NASA Earthdata datasets.

Local test steps

Added new unit tests, and all pass.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

@danielfromearth danielfromearth self-assigned this Dec 31, 2024
@danielfromearth danielfromearth added the enhancement New feature or request label Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 97.68977% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.53%. Comparing base (048f2f8) to head (3233262).
Report is 23 commits behind head on develop.

Files with missing lines Patch % Lines
ncompare/getters.py 92.53% 5 Missing ⚠️
ncompare/Comparison.py 98.90% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #281      +/-   ##
===========================================
+ Coverage    92.01%   94.53%   +2.51%     
===========================================
  Files            6        9       +3     
  Lines          426      531     +105     
===========================================
+ Hits           392      502     +110     
+ Misses          34       29       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth marked this pull request as ready for review January 3, 2025 21:51
@danielfromearth danielfromearth marked this pull request as draft January 3, 2025 21:52
@danielfromearth danielfromearth marked this pull request as ready for review January 6, 2025 15:20
@danielfromearth danielfromearth merged commit 1bca5b3 into develop Jan 6, 2025
9 checks passed
@danielfromearth danielfromearth deleted the feature/issue-82-expand-compatibility-to-general-hdf-files branch January 6, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request to expand compatibility to general HDF files and compare with nc
1 participant