-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 82 expand compatibility to general hdf files #281
Merged
danielfromearth
merged 20 commits into
develop
from
feature/issue-82-expand-compatibility-to-general-hdf-files
Jan 6, 2025
Merged
Feature/issue 82 expand compatibility to general hdf files #281
danielfromearth
merged 20 commits into
develop
from
feature/issue-82-expand-compatibility-to-general-hdf-files
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #281 +/- ##
===========================================
+ Coverage 92.01% 94.53% +2.51%
===========================================
Files 6 9 +3
Lines 426 531 +105
===========================================
+ Hits 392 502 +110
+ Misses 34 29 -5 ☔ View full report in Codecov by Sentry. |
…general-hdf-files
danielfromearth
deleted the
feature/issue-82-expand-compatibility-to-general-hdf-files
branch
January 6, 2025 15:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #82
Description
This change enables comparisons of HDF5 files. It has been tested across a variety of NASA Earthdata datasets.
Local test steps
Added new unit tests, and all pass.
PR Acceptance Checklist
CHANGELOG.md
updated