-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#348] FSW unit tests in CI #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd resolve sample component unit test pathing;
The following works locally for me, but not in GitHub CI for some reason:
|
jlucas9
changed the title
[nasa/nos3#348] FSW unit tests in CI
WIP: [nasa/nos3#348] FSW unit tests in CI
Oct 18, 2024
@rjbrown2 and @Donnie-Ice could you assist here? I'm at a loss as to why I'm good locally but failing in CI |
jlucas9
force-pushed
the
nos3#348
branch
3 times, most recently
from
November 15, 2024 17:11
62b8706
to
5e25cdb
Compare
jlucas9
changed the title
WIP: [nasa/nos3#348] FSW unit tests in CI
[nasa/nos3#348] FSW unit tests in CI
Nov 15, 2024
jlucas9
requested review from
msuder,
Donnie-Ice,
kevincbruce,
rjbrown2,
dacarter22,
zlynch2 and
Isgaroth-the-Green
November 15, 2024 18:59
msuder
approved these changes
Nov 18, 2024
Reviewed code and ran tests and everything seemed ok. |
dacarter22
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests ran successfully on my machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the following submodules to be merged prior: