Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#348] FSW unit tests in CI #393

Merged
merged 7 commits into from
Nov 20, 2024
Merged

[nasa/nos3#348] FSW unit tests in CI #393

merged 7 commits into from
Nov 20, 2024

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Oct 18, 2024

…nd resolve sample component unit test pathing;
@jlucas9 jlucas9 self-assigned this Oct 18, 2024
@jlucas9
Copy link
Contributor Author

jlucas9 commented Oct 18, 2024

The following works locally for me, but not in GitHub CI for some reason:

make debug
make config
make build-test
make test-fsw

@jlucas9 jlucas9 changed the title [nasa/nos3#348] FSW unit tests in CI WIP: [nasa/nos3#348] FSW unit tests in CI Oct 18, 2024
@jlucas9
Copy link
Contributor Author

jlucas9 commented Oct 22, 2024

@rjbrown2 and @Donnie-Ice could you assist here? I'm at a loss as to why I'm good locally but failing in CI

@jlucas9 jlucas9 force-pushed the nos3#348 branch 3 times, most recently from 62b8706 to 5e25cdb Compare November 15, 2024 17:11
@jlucas9 jlucas9 changed the title WIP: [nasa/nos3#348] FSW unit tests in CI [nasa/nos3#348] FSW unit tests in CI Nov 15, 2024
@msuder
Copy link
Contributor

msuder commented Nov 18, 2024

Reviewed code and ran tests and everything seemed ok.

@Isgaroth-the-Green
Copy link
Contributor

When I ran the tests, I got two tests failing:
image
Is this acceptable/expected behavior, or should I try changing something to get them to pass?

Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests ran successfully on my machine

@jlucas9
Copy link
Contributor Author

jlucas9 commented Nov 20, 2024

When I ran the tests, I got two tests failing: image Is this acceptable/expected behavior, or should I try changing something to get them to pass?

I would thing this has something to do with Windows 11 and HyperV for those. Will continue to track and see if we can get failures other ways

@jlucas9 jlucas9 merged commit cf90de4 into dev Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants