Add some "Special Casing" support to String#downcase, String#upcase, and String#titlecase #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used by codepoint_to_uppercase et al in a later commit.
I considered using std::tuple for this, but I fell back to doing it the C way since, because I understand how efficient it is.
This doesn't handle Lithuanian or Turkish stuff. I'm not sure what I need for that yet.
Again, no Lithuanian or Turkish stuff yet.
Again, no Lithuanian or Turkish stuff yet. This doesn't make any additional specs pass, unfortunately, because there are no "unconditional mappings" for lowercase. This will still be useful when we add Turkish and Lithuanian support though.
seven1m
force-pushed
the
casemap-special-casing
branch
from
1941101 to
d7165be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#217
This is the set of mappings from the "Unconditional mappings" section of http://ftp.unicode.org/Public/UNIDATA/SpecialCasing.txt.