Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make String#index mostly spec-compliant #2115

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Make String#index mostly spec-compliant #2115

merged 1 commit into from
Jun 17, 2024

Conversation

seven1m
Copy link
Member

@seven1m seven1m commented Jun 16, 2024 •
edited
Loading

#217

This gets most of the specs passing, except a couple encoding ones.

@seven1m seven1m marked this pull request as draft June 16, 2024 15:30
@seven1m
Copy link
Member Author

seven1m commented Jun 16, 2024 •
edited
Loading

I’m going to look at this again. I wonder if we should delegate to Regexp#=~ since it does basically the same thing? (Or does it?) Naa, we need a starting offset. Imma just go with this...

@seven1m seven1m force-pushed the string-index-regexp branch from c1f443a to 1db97c1 Compare June 17, 2024 03:59
@seven1m seven1m marked this pull request as ready for review June 17, 2024 03:59
@seven1m seven1m changed the title Add support for regexp passed to String#index Make String#index mostly spec-compliant Jun 17, 2024
@seven1m seven1m force-pushed the string-index-regexp branch from 1db97c1 to 45d95ea Compare June 17, 2024 11:51
@seven1m seven1m merged commit 74cbc7f into master Jun 17, 2024
15 checks passed
@seven1m seven1m deleted the string-index-regexp branch June 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seven1m