Add :invalid and :replace options to String#encode #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and implement Utf8EncodingObject::next_char using it.
In addition to giving a number instead of a StringView, next_codepoint
is greedy, consuming as many bytes as makes sense for the encoding, even
if an incomplete character would be produced.
This is hard to demonstrate in pure Ruby, but this kinda shows it:
# a valid four-byte character
"\xF0\x9F\x98\x81".chars => ["😁"]
# last byte is invalid, four one-byte chars returned
"\xF0\x9F\x98_".chars => ["\xF0", "\x9F", "\x98", "_"]
# changing encoding needs greedy consumption of
# the first three bytes
"\xF0\x9F\x98_".encode('utf-16le', invalid: :replace).chars
=> ["\uFFFD", "_"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What a yak shave. 😅 Adding
EncodingObject::next_codepoint()is a big win though.#217