Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behaviour of Enumerator#with_index with block #2153

Closed
wants to merge 1 commit into from
Closed

Fix behaviour of Enumerator#with_index with block #2153

wants to merge 1 commit into from

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Jun 26, 2024

Fixes #2150

@herwinw herwinw self-assigned this Jun 26, 2024
@herwinw
Copy link
Member Author

herwinw commented Jun 26, 2024

Mental note: this added spec file is called each_with_index_spec.rb, but includes a few specs for Enumerator#with_index. This should probably be fixed upstream.

@herwinw herwinw mentioned this pull request Dec 30, 2024
Merged
@herwinw herwinw closed this Dec 30, 2024
@herwinw herwinw deleted the enumerator_with_index branch December 30, 2024 11:03
@herwinw
Copy link
Member Author

herwinw commented Dec 30, 2024

Mental note: this added spec file is called each_with_index_spec.rb, but includes a few specs for Enumerator#with_index. This should probably be fixed upstream.

This has been fixed upstream, we will get to this at some point, but I don't really need this change any more than any other bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@herwinw herwinw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling with_index with a block on an enumerator results in the wrong output type
1 participant
@herwinw