Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make String#insert spec-compliant #2163

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Make String#insert spec-compliant #2163

merged 4 commits into from
Jun 28, 2024

Conversation

seven1m
Copy link
Member

@seven1m seven1m commented Jun 28, 2024

seven1m added 4 commits June 28, 2024 10:08
@seven1m
Remove unused String::insert method
753726d 
This one is pretty unsafe since it has no bounds checking and it's not
used anywhere.
@seven1m
Update TM lib
2dc0711 
This adds support for String::append(ssize_t).
@seven1m
Allow converting negative char index for insert too
8c1e54e 
...and check we don't go out of bounds.
@seven1m
Refactor String#insert and make spec-compliant
d986791
@seven1m seven1m merged commit e940215 into master Jun 28, 2024
15 checks passed
@seven1m seven1m deleted the string-insert branch June 28, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@seven1m