Golang goroutine result issue #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corentone
commented
Oct 20, 2020
| @@ -160,6 +160,7 @@ func main() { | |||
| messages <- 3 | |||
| }() | |||
| go func() { | |||
| // we should wait for completion here? | |||
|
Tagging you per the article; sorry its super old, I was looking for a nice pattern and found your blog but Im thinking there is a potential issue :) The playground that shows it: |
|
I found a solution with just adding another wait group; For your article it may be easier to just not deal with the result and do the printing in the work goroutine |
nathanleclaire
force-pushed
the
master
branch
4 times, most recently
from
0b0cc4b
to
06d55fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are we correctly waiting for result processing?
Since we only wait on
wg.Wait()it could return before all the println have happened since we dont wait for that.We should somehow also have a mechanism to wait for all the messages to have been processed. Im still trying to think what would be the cleanest solution.