Skip to content

Commit

Permalink
Merge pull request #263 from nathantannar4/bottomGapFix
Browse files Browse the repository at this point in the history
Fix bottom gap calculations for embedded controllers
  • Loading branch information
Kaspik authored Jul 11, 2024
2 parents 17ced92 + bd00bc5 commit 093bdc7
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci_master_framework.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ jobs:
runs-on: macOS-latest
steps:
- name: Checkout the Git repository
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build framework
run: ./GitHubActions/build.sh framework
2 changes: 1 addition & 1 deletion .github/workflows/ci_pr_example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ jobs:
runs-on: macOS-latest
steps:
- name: Checkout the Git repository
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build and run example project
run: ./GitHubActions/build.sh example
2 changes: 1 addition & 1 deletion .github/workflows/ci_pr_framework.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ jobs:
runs-on: macOS-latest
steps:
- name: Checkout the Git repository
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Build framework
run: ./GitHubActions/build.sh framework
4 changes: 2 additions & 2 deletions GitHubActions/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ MODE="$1"

if [ "$MODE" = "framework" -o "$MODE" = "all" ]; then
echo "Building InputBarAccessoryView Framework."
set -o pipefail && xcodebuild build -scheme InputBarAccessoryView -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 11" | xcpretty -c
set -o pipefail && xcodebuild build -scheme InputBarAccessoryView -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 14" | xcpretty -c
success="1"
fi

if [ "$MODE" = "example" -o "$MODE" = "all" ]; then
echo "Building InputBarAccessoryView Example app."
set -o pipefail && xcodebuild build -project Example/Example.xcodeproj -scheme Example -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 11 Pro" | xcpretty -c
set -o pipefail && xcodebuild build -project Example/Example.xcodeproj -scheme Example -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 14 Pro" | xcpretty -c
success="1"
fi

Expand Down
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// swift-tools-version:5.5
// swift-tools-version:5.9
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription
Expand Down
2 changes: 1 addition & 1 deletion Sources/KeyboardManager/KeyboardManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ open class KeyboardManager: NSObject, UIGestureRecognizerDelegate {
/// This value represents the size of the gap between the bottom of the screen and the bottom of the inputAccessoryView.
private var bottomGap: CGFloat {
if let inputAccessoryView = inputAccessoryView, let window = inputAccessoryView.window, let superView = inputAccessoryView.superview {
return window.frame.height - superView.convert(superView.frame, to: window).maxY
return window.frame.height - window.convert(superView.frame, to: window).maxY
}
return 0
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ open class AttachmentCell: UICollectionViewCell {
button.layer.cornerRadius = 10
button.clipsToBounds = true
button.backgroundColor = .systemBlue
button.addTarget(self, action: #selector(deleteAttachment), for: .touchUpInside)
button.addTarget(self, action: #selector(self?.deleteAttachment), for: .touchUpInside)
return button
}()

Expand Down

0 comments on commit 093bdc7

Please sign in to comment.