Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sepolia #147

Merged
merged 5 commits into from
Mar 2, 2024
Merged

feat: support sepolia #147

merged 5 commits into from
Mar 2, 2024

Conversation

TTNguyenDev
Copy link
Contributor

@TTNguyenDev TTNguyenDev commented Mar 1, 2024

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agreements-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 2:44am
agreements-app-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 2:44am

@TTNguyenDev TTNguyenDev requested a review from aahna-ashina March 1, 2024 13:14
@TTNguyenDev
Copy link
Contributor Author

TTNguyenDev commented Mar 1, 2024

Please check this PR. #136 closed

@TTNguyenDev
Copy link
Contributor Author

@aahna-ashina I'm wondering what is the cohort address for sepolia?

aahna-ashina
aahna-ashina previously approved these changes Mar 1, 2024
Copy link
Member

@aahna-ashina aahna-ashina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

const apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY; //mainnet
let apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY;
if (chain?.id == 11155111) {
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY_SEPOLIA;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY_SEPOLIA;
apiKey = process.env.NEXT_PUBLIC_ALCHEMY_API_KEY;

export const arbitratorAddress = "0xBe67cEdCD1FE38aac8a5781A51250FDeFB344E6C";
export const cohortAddress = "0xfbb66bc799308435ed2a0e0c0ac3ad1d46749b7b";
export const safeTxServiceUrl = "https://safe-transaction-sepolia.safe.global";
export const subgraphURI = process.env.NEXT_PUBLIC_GRAPH_API_URL_SEPOLIA;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const subgraphURI = process.env.NEXT_PUBLIC_GRAPH_API_URL_SEPOLIA;
export const subgraphURI = process.env.NEXT_PUBLIC_GRAPH_API_URL;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that https://agreements.nation3.org/ supports only the Ethereum mainnet, and https://sepolia.agreements.nation3.org/ supports only the Sepolia testnet, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't support network switching?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't support network switching?

We can still support it, by redirecting to the other URLs. If a user opens https://agreements.nation3.org and selects Sepolia in the chain selection drop-down, we can redirect to https://agreements-sepolia.nation3.org

@aahna-ashina
Copy link
Member

@aahna-ashina I'm wondering what is the cohort address for sepolia?

Sorry, I don't know what the cohortAdress is for. Maybe there is some documentation mentioning what "cohort" means here?

@TTNguyenDev
Copy link
Contributor Author

@aahna-ashina this is cohort address on mainnet export const cohortAddress = "0xee8F0B89983aF83598E6Fb503B9f6e5eaf23b243";

@TTNguyenDev
Copy link
Contributor Author

https://etherscan.io/address/0xee8F0B89983aF83598E6Fb503B9f6e5eaf23b243#code

@aahna-ashina
Copy link
Member

aahna-ashina commented Mar 2, 2024

@aahna-ashina this is cohort address on mainnet export const cohortAddress = "0xee8F0B89983aF83598E6Fb503B9f6e5eaf23b243";

Okay, so a cohort will always be a Gnosis safe? I just don't understand the meaning of "cohort" in this context. The variable should have a different name so that everyone can understand what it's for. Can we rename it to something more meaningful? (Can be done in a separate pull request.)

@TTNguyenDev TTNguyenDev merged commit 4d699a1 into main Mar 2, 2024
10 checks passed
@TTNguyenDev TTNguyenDev deleted the build/sepolia branch March 2, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants