Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate general purpose snippets still in 5ePHB theme to Blank #3664

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dbolack-ab
Copy link
Collaborator

@dbolack-ab dbolack-ab commented Aug 23, 2024

This relocates a significant number of Snippets from the V3/5ePHB theme to the V3/Blank theme

  • Text Editor Menu
    • Table of Contents
    • Index
  • Style Editor Menu
  • Remove Drop cap
  • Tweak Drop cap

It also removes redundant entries:

  • Images Menu
    • Image
    • Background Image
    • Watermark

Solves #3602

@dbolack-ab dbolack-ab marked this pull request as draft August 23, 2024 19:27
@5e-Cleric 5e-Cleric changed the title Relocate general purpose snippets still in 53PHB theme to Blank Relocate general purpose snippets still in 5ePHB theme to Blank Aug 23, 2024
@5e-Cleric
Copy link
Member

Remove Drop cap
Tweak Drop cap

We should then add a drop cap to the blank theme as well, probably not a bad idea.

@5e-Cleric
Copy link
Member

Hey hey hey! the styles for the cover page should remain in the PHB theme! Those fonts and assets are from the phb theme, Blank should have a cover, but neither the markdown nor the less should be the same as in the PHB

@dbolack-ab dbolack-ab self-assigned this Sep 1, 2024
@5e-Cleric 5e-Cleric added UI/UX User Interface, user experience Approved Has been discussed and an approach is agreed upon 🔍 R_ - Not ready for review 🕑 labels Oct 28, 2024
@dbolack-ab
Copy link
Collaborator Author

Hey hey hey! the styles for the cover page should remain in the PHB theme! Those fonts and assets are from the phb theme, Blank should have a cover, but neither the markdown nor the less should be the same as in the PHB

I reverted this back then but it leads me to questions:

  1. Should Blank be the base theme that is loaded for Homebrewery ( not Brews, but the app ) instead of 5ePHB? Or should we establish a distinct Homebrewery theme that decouples this from the Brew theme ( even if it is initially indistinct ). I know this is a little bit of a tangent to this PR and probably should be handled as a distinct task - but it factors into the thinking

  2. Regarding the styles and such that were moved, I will clone those, lacking the font definitions for now. We may want to have a separate discussion as to if we want specific faces to be the defaults for Blank as opposed to system/browser defaults.

@5e-Cleric
Copy link
Member

questions:

  1. Should Blank be the base theme that is loaded for Homebrewery ( not Brews, but the app ) instead of 5ePHB? Or should we establish a distinct Homebrewery theme that decouples this from the Brew theme ( even if it is initially indistinct ). I know this is a little bit of a tangent to this PR and probably should be handled as a distinct task - but it factors into the thinking

There has been discussion about this, but we have never reached a full consensus, first, we want to decouple the HB from the brews, meaning, style for both should be kept separate, the blank theme only contains CSS for the brews.

Even if we made a Homebrewery theme, we should keep blank, for other themes to be built over it without having to worry about little stuff, this is my personal opinion, and, i believe, the team's(if i recall correctly)

I believe we should improve the blank theme to a more apt version of itself, adding covers and a TOC styling should help, but we don't need to make more changes than necessary, and changing the blank theme would today impact all themes out there, so also all brews out there.

We are open to talk about this, definitely.

  1. Regarding the styles and such that were moved, I will clone those, lacking the font definitions for now. We may want to have a separate discussion as to if we want specific faces to be the defaults for Blank as opposed to system/browser defaults.

I will assume that by faces you mean typefaces, yeah, not sure either of what the blank theme styling should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Has been discussed and an approach is agreed upon 🔍 R_ - Not ready for review 🕑 UI/UX User Interface, user experience
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

4 participants