-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate general purpose snippets still in 5ePHB theme to Blank #3664
base: master
Are you sure you want to change the base?
Conversation
Should include all supporting style content.
We should then add a drop cap to the blank theme as well, probably not a bad idea. |
Hey hey hey! the styles for the cover page should remain in the PHB theme! Those fonts and assets are from the phb theme, Blank should have a cover, but neither the markdown nor the less should be the same as in the PHB |
This reverts commit ad1dfc8.
I reverted this back then but it leads me to questions:
|
There has been discussion about this, but we have never reached a full consensus, first, we want to decouple the HB from the brews, meaning, style for both should be kept separate, the blank theme only contains CSS for the brews. Even if we made a Homebrewery theme, we should keep blank, for other themes to be built over it without having to worry about little stuff, this is my personal opinion, and, i believe, the team's(if i recall correctly) I believe we should improve the blank theme to a more apt version of itself, adding covers and a TOC styling should help, but we don't need to make more changes than necessary, and changing the blank theme would today impact all themes out there, so also all brews out there. We are open to talk about this, definitely.
I will assume that by faces you mean typefaces, yeah, not sure either of what the blank theme styling should be. |
This relocates a significant number of Snippets from the V3/5ePHB theme to the V3/Blank theme
It also removes redundant entries:
Solves #3602