-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4 proposed aligned paragraph tokens #3908
base: master
Are you sure you want to change the base?
Conversation
As long as these syntaxes don't conflict with existing documents, we should be able to just add them to V3. I think this one should be pretty safe. |
i want to test this |
Three thoughts: First, the table syntax this borrows from allows any number of hyphens in the construction. Is it valuable to allow that here as well? For example:
Second, is it valuable to allow this syntax on the first line of a paragraph
Third, we should aim to have Markdown convert to pure HTML, so they do not rely upon CSS to function. In this case, we have the All this said, please don't start writing code for the first two unless we get a consensus, so you don't have to undo it later. |
Technically, since that ¶ is unmarked it should default back to the default .. which in many themes might be left-aligned, but could also conceivably be full-aligned in some themes. I suggest
|
I'm dubious, but I don't see any reason that there needs to be a fixed number unless we want to ascribe value based on the number of hyphens ( example - 1: use HTML Align 2: use class )
I think it is better suited to being a lead-in paragraph-marker.
I chose to use a class instead of the property so that users could overload the feature with additional styling. If we do it with the property, users lose that option and must {{}} it as-well. |
To be fair, centered text is something common to most if not all themes, i'm not sure of the value of the overriding possibility. Not against it. |
I'm guessing I explained that poorly? I dunno. The notion that a brew or theme could choose to override and extend what |
Description
This implements the suggested syntax for V4 paragraph text alignment tokens from #2879
Related Issues or Discussions
#2879
QA Instructions, Screenshots, Recordings
:-
in front of a paragraph. It should align left. You should see a class of mdParagraphJustifyLeft on the paragraph tag-:
in front of a paragraph. It should align right. You should see a class of mdParagraphJustifyRight on the paragraph tag:-:
in front of a paragraph. It should align center. You should see a class of mdParagraphJustifyCenter on the paragraph tagReviewer Checklist