support oscillation angle in move_base #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knorth55
changed the title
siferati
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
@corot So it seems like mbf already has dynamic config for the oscillation parameters, but we're not using them for the exe_path action? Wouldn't it be better to re-use them instead of reading them from parameter server? 🤔
Co-authored-by: Tiago Silva <[email protected]>
siferati
requested changes
Nov 21, 2023
This reverts commit 5b1f67a.
siferati
approved these changes
Nov 22, 2023
corot
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR needs #334
this PR adds oscillation angle feature in
move_base.now only
exe_pathhas theoscillation_anglefeature, but it is also useful formove_base, too.