Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct keys to check for passwords #374

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: correct keys to check for passwords #374

merged 1 commit into from
Apr 24, 2024

Conversation

m4rg4sh
Copy link
Contributor

@m4rg4sh m4rg4sh commented Apr 2, 2024

Fixes: #373

Fixes incorrectly defined list of keys to check for password(s).

@m4rg4sh m4rg4sh marked this pull request as ready for review April 2, 2024 14:59
@m4rg4sh m4rg4sh requested a review from ubajze as a code owner April 2, 2024 14:59
@gertzakis
Copy link
Contributor

Hey @m4rg4sh , is this PR also fixes #375? Because I think there is also a problem with not using pore existing secrets for postgresql and redis

@m4rg4sh
Copy link
Contributor Author

m4rg4sh commented Apr 4, 2024 •
edited
Loading

@gertzakis Can you share the steps/commands needed to reproduce #375? Then I can see how it behaves on my fork.

@ubajze ubajze merged commit 7cab2b0 into nautobot:develop Apr 24, 2024
3 of 4 checks passed
@ubajze ubajze mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubajze ubajze ubajze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to version 2.1.0 broken using only nautobot.secretKey
3 participants
@m4rg4sh @gertzakis @ubajze