Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-810: Updated custom remediation for non-str object types #819

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

emdeefive
Copy link
Contributor

@emdeefive emdeefive commented Oct 11, 2024

Closes #810

What's Changed

In #810, a client received an exception when the join method was used on a dict custom remediation object.

The fix is simply to verify the object type of the custom remediation before creating the ConfigPlan object.

Manual testing verified that this fix worked with a traditional custom remediation as well as a dict object.

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • n/a Attached Screenshots, Payload Example
  • n/a Unit, Integration Tests
  • n/a Documentation Updates (when adding/changing features)
  • n/a Example App Updates (when adding/changing features)
  • n/a Outline Remaining Work, Constraints from Design

Copy link
Contributor

@jeffkala jeffkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itdependsnetworks you're good to merge?

@itdependsnetworks itdependsnetworks merged commit a62ab68 into develop Oct 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A custom remediation that is not a string raises an exception on config plan generation
3 participants