Remove conditional views in Golden Config #847
+631
−640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtdub
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
jtdub
force-pushed
the
gc-app-settings
branch
from
49c3e1d to
a3d7a71
Compare
jtdub
force-pushed
the
gc-app-settings
branch
from
47e4b89 to
3113bf9
Compare
jtdub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the first portion of the proposed functionality in #842.
The second portion of the proposed functionality requires further review. My initial investigation indicates that it may degrade the performance of the golden config, as the UI-based configuration settings would apply to each device individually within a dynamic group, rather than checking the configuration globally once.