Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify_in_ssl log statement which no longer has access to SSL params #202

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

chouinar
Copy link
Contributor

Ticket

#200

Changes

Removes log statement that relies on variables no longer in psycopg 3.

Context for reviewers

The upgrade to psycopg3 got this error during migrations: AttributeError: 'ConnectionInfo' object has no attribute 'ssl_attribute_names' - https://github.com/navapbc/platform-test-flask/actions/runs/6275581568/job/17043454952

These aren't available anymore and looking through the connection info object, I don't see any equivalent. Looking at the docs for version 2, these attributes say Only available if psycopg was built with libpq >= 9.5 https://www.psycopg.org/docs/extensions.html#psycopg2.extensions.ConnectionInfo.ssl_attribute

While the docs for psycopg3 mention libpq as being the backing library it uses, I don't see any mention of these parameters in their docs. https://www.psycopg.org/psycopg3/docs/api/connections.html#psycopg.Connection.pgconn - so seems to just be gone entirely?

Testing

Updated tests

@chouinar chouinar requested a review from lorenyu September 22, 2023 15:14
Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for the fix

@chouinar chouinar merged commit b4d289a into main Sep 22, 2023
4 checks passed
@chouinar chouinar deleted the chouinar/fix-ssl-logging branch September 22, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants