Fix flaky test test_bulk_upsert #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
approved these changes
Jun 17, 2024
Comment on lines
+18
to
+25
| _next_id = 0 | ||
|
|
||
|
|
||
| def get_random_number_object() -> Number: | ||
| global _next_id | ||
| _next_id += 1 | ||
| return Number( | ||
| id=str(random.randint(1000000, 9999999)), | ||
| id=str(_next_id), |
There was a problem hiding this comment.
(not required - just throwing an idea out) You could use Factory boy for building these. While we normally use it for DB models, it also supports creating a dict. Mostly would help with not needing to manage a global counter.
https://github.com/navapbc/simpler-grants-gov/blob/main/api/tests/src/db/models/factories.py#L1269
Not really necessary for just this, but if this was expanded significantly in use I'd recommend it.
There was a problem hiding this comment.
Oh nice! I'll defer that change for now, thanks for sharing (also, very convenient that the grants.gov project is open source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
n/a
Changes
Context for reviewers
Testing
First, (temporarily) add pytest-repeat:
poetry add pytest-repeatThen run the test several thousand times:
make test args="tests/src/db/test_bulk_ops.py --count 2500"You should observe some failures because a duplicate ID is generated:
Then, re-run after applying the patch: