Update packages & setup docker-compose to allow override.env file #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Dec 10, 2024
KevinJBoyer
approved these changes
Dec 11, 2024
KevinJBoyer
reviewed
Dec 11, 2024
Co-authored-by: Kevin Boyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Changes
Updated Python packages
Add support for an override.env file
Context for reviewers
These python package updates mirror similar ones we've done already on Simpler Grants.gov, so not concerned with any of them.
The override.env file uses something added to Docker in January 2024: https://docs.docker.com/reference/compose-file/services/#required - in short, you can specify multiple .env files and have some be optional. This way we can always say to look for override.env, but not require it, and allow a user to write whatever they want to it without checking it in.
Testing
Locally I was able to create override.env, it not be added to git, and the overrides worked (changed
LOG_FORMATtojsonand back).