IS-2728: Combine filterpanel to one #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Burde denne renames? Nå når dette ikke egentlig er et panel? 😊
|
Regner med det er avklart at disse panelene ikke lenger skal være expandable/collapsable? :) Ser ingen grunn til at de trenger være det egentlig. |
| /> | ||
| </div> | ||
| </Ekspanderbartpanel> | ||
| <div className="flex flex-col gap-4"> |
There was a problem hiding this comment.
Kan evt endre til å bruke VStack
andersrognstad
approved these changes
Nov 25, 2024
ingring
force-pushed
the
IS-2728-combine-filterpanel-to-one
branch
from
bba0c44
to
39b8f77
Compare
eirikdahlen
approved these changes
Nov 26, 2024
Comment on lines
+14
to
+18
| <TextField | ||
| size="small" | ||
| label={texts.undertittel} | ||
| value={filterState.tekstFilter} | ||
| onChange={(e) => { |
There was a problem hiding this comment.
Snakket med Peter om å fjerne description her? Tenker at nå som vi får søk, så burde det være tydelig at dette ikke er et søk, men et filter. Man kunne beholdt samme description som før, men bare endret teksten fra Søk på navn eller fødselsnummer -> Filtrer på navn eller fødselsnummer eller noe sånt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hva har blitt lagt til✨🌈
Lagt alle filtrene i oversikten i samme panel for å spare plass og muligens synliggjøre filtermulighetene i morra. Vi måler allerede bruk av hendelsesfilteret, alder og dato i amplitude, så det blir spennende å se om bruken øker.
Screenshots 📸✨