Skip to content

Commit

Permalink
Remove default share options
Browse files Browse the repository at this point in the history
For two reasons:
1. Easier maintenance, with the widget generating the HTML and overriding this HTML, it was not immediately clear where to make the edits/additions to share options. Both places?
2. Removes a flash of unstyled content

We still need the input element because a label exists outside of this that references the input. Without that input, validation would result in an error.
  • Loading branch information
mfairchild365 committed Dec 23, 2015
1 parent 214a208 commit 666645f
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions wdn/templates_4.1/includes/share.html
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
<div class="wdn-share-this-page wdn-dropdown-widget-content" id="wdn-main-share-button">
<div class="wdn-share-button">
<input type="checkbox" id="wdn-main-share-button-wdn-share-toggle" value="Show share options" class="wdn-input-driver wdn-dropdown-widget-toggle" aria-controls="wdn-share-options" />
<input type="checkbox" id="wdn-main-share-button-wdn-share-toggle" value="Show share options" class="wdn-input-driver wdn-dropdown-widget-toggle" />
<label for="wdn-main-share-button-wdn-share-toggle" class="wdn-icon-share"><span class="wdn-text-hidden">Share This Page</span></label>
<ul id="wdn-share-options">
<li><a href="http://go.unl.edu/?url=referer" id="wdn_createGoURL" class="wdn-icon-link" rel="nofollow">Get a Go URL</a></li>
<li class="outpost" id="wdn_emailthis"><a href="mailto:" class="wdn-icon-mail" rel="nofollow">Email this page</a></li>
<li class="outpost" id="wdn_facebook"><a href="https://www.facebook.com/sharer/sharer.php" class="wdn-icon-facebook" rel="nofollow">Share on Facebook</a></li>
<li class="outpost" id="wdn_twitter"><a href="https://twitter.com/share" class="wdn-icon-twitter" rel="nofollow">Share on Twitter</a></li>
<li class="outpost" id="wdn_linkedin"><a href="https://www.linkedin.com/shareArticle?mini=true" class="wdn-icon-linkedin-squared" rel="nofollow">Share on LinkedIn</a></li>
</ul>
</div>
</div>

0 comments on commit 666645f

Please sign in to comment.