Simplified Chemical registration form #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajla
changed the title
bartapes
reviewed
Apr 2, 2024
…egistration_form # Conflicts: # package.json # src/app/core/substance-form/substance-form.component.html # src/app/core/substance-form/substance-form.component.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
This PR adds 3 new components:
simplified-namessimplified-codessimplified-referencesThey all reference the same underlying Angular services as the non-simplified components so they are as easy to plug-in and use.
Chemical (Simplified) new navigation
New navigation element.
substance-form-componentknows to identify it as a simplified form and enable the appropriate flag.Modified
Changed
substance-form-componentto look for a simplified form flag, and based on it switch the current style with something more compact and use the simplified components.Changed
substance-form-serviceto support setting default substance form values.Changed some import export stuff in the
referencesmodule to allow some code to be used insimplified-references.Notes
Might be easier to review commit by commit, since there are commits with only dead code deletion or spacing changes.