Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align IVM parsing to other plugin parsing #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tylerperyea
Copy link
Collaborator

The parsing of plugins/extensions in GSRS largely follows the same pattern:

extension:{
  releventClass:<class_name>,
  //optional parameters
  parameters:{
      parameter1:value1,
      ...
  }
}

We usually use "parameters" but also allow for the same variables to be put in the main config object instead, like:

extension:{
  releventClass:<class_name>,
  //optional parameters
  parameter1:value1
}

This is done like this for scheduledTasks, import functions, export functions, validators and a few other extensions. IVMs are one of the few that doesn't support the alternative representation. Here, this PR allows it to work like the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant