Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt some optimizations implemented by LIRMM in 2023 #34

Merged
merged 12 commits into from
Sep 4, 2024

Conversation

jvendetti
Copy link
Member

This pull request adopts some of the optimizations implemented by our LIRMM collaborators in their version of this library. The highlights include:

  • Deprecate the find method in favor of get
  • Modify the get method to add collection paths if not provided
  • Stop refreshing the cache for all ontologies, submissions, and users when updating individual objects
  • Cache the result of calls to top_level_links (the set of links never changes)

A more detailed explanation of these optimizations is available here: ontoportal-lirmm#14. The purpose of ingesting these optimizations now is part of a larger effort to address recent system instability in the BioPortal Ruby on Rails application: ncbo/bioportal-project#320.

Also included in this pull request:

  • Remove the no longer used refresh_cache method
  • Remove the no longer used spawnling dependency
  • Bump minitest from 5.24.1 to 5.25.1
  • Fix some RuboCop warnings

@jvendetti jvendetti self-assigned this Aug 21, 2024
@jvendetti jvendetti merged commit f589b13 into master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant