Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Develop to Master, release v5.28.0 #187

Merged
merged 28 commits into from
Feb 7, 2024
Merged

Merge Develop to Master, release v5.28.0 #187

merged 28 commits into from
Feb 7, 2024

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Feb 7, 2024 •
edited
Loading

syphax-bouazzouni and others added 25 commits April 4, 2022 14:30
@syphax-bouazzouni
auto lint refactor
574da21
@syphax-bouazzouni
remove the Bioportal harder coded constant in notification subjects
b7a4856
@syphax-bouazzouni
send the ontology pull failure notification also to the portal admins
d837cea
@syphax-bouazzouni
adding a notification for new users creation
339a268
@syphax-bouazzouni
add a notification for new ontology creation
402e361
@syphax-bouazzouni
removing duplicate if found in the notify recipients
c66eaf0
@syphax-bouazzouni
configurize the hardcoded Bioportal name
c18270d
@syphax-bouazzouni
fix empty admin_emails value test
fcd5bbd
@syphax-bouazzouni
extract the notifier (sender) from the notifications (the content)
a31727c
@syphax-bouazzouni
add the ontology administrators to the processing notification targets
90798af
@syphax-bouazzouni
replace ui_host with ui_name
31d146e
@syphax-bouazzouni
use ui_name in the tests
ee73818
@syphax-bouazzouni
Merge branch 'master' into pl/refacotor-notification
90bea9d
@syphax-bouazzouni
fix mailer configuration when using login auth option
10d3248
@syphax-bouazzouni
refactor notifications of notes and reset password
f5b9478
@syphax-bouazzouni
use id_url_prefix in generating note id instead of of hardcoded value
e6f1dac
@alexskr
Merge pull request #148 from ontoportal-lirmm/pl/refacotor-notification
dca560d 
Refactor: notifications
@alexskr
notification refactor follow up
6d193bd 
- Rename variables and methods to make a clear distinction between
  OntoPortal site admins, ontology admins and support.
- Add new feature to optionally disable notifications send to OntoPortal
  admins for each event associated with ontology creation, new user, etc
- LinkedData.setting.support_contact_email is a new configuration option
  for setting end user support contact email.
  BioPortal requires different emails for contacting BioPortal site
  admins and end user support

In order to clarify the distinction between the OntoPortal site admins and
ontology owners/admins the following settings and methods are renamed:

LinkedData.setting.admin_emails is renamed to ontoportal_admin_emails
LinkedData::Utils::Notifier.admin_mails -> ontology_admin_emails
LinkedData::Utils::support_mails -> ontoportal_admin_emails
LinkedData::Utils::notify_support_grouped -> notify_ontoportal_admins_grouped
@alexskr
add enable_administrative_notifications condition
0913930
@alexskr
add unit test for disabling administrative notifications
12daf06
@alexskr
minor optimizations
d0b6ad8
@alexskr
Remove backward compatibility check.
87afcc4
@alexskr
Merge pull request #184 from ncbo/pr-refacotor-notification
247fb4d 
refactor notification
@alexskr
add attribute for storing reset token expire time
073f79d
@alexskr
fix archived submission notification email shows failure in subject
602a44c
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (4b6b7f4) 80.76% compared to head (5900570) 79.96%.
Report is 9 commits behind head on master.

❗ Current head 5900570 differs from pull request most recent head 1e8bd29. Consider uploading reports for the commit 1e8bd29 to get more accurate results

Files Patch % Lines
lib/ontologies_linked_data/utils/notifications.rb 61.97% 27 Missing ⚠️
lib/ontologies_linked_data/utils/notifier.rb 94.82% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   80.76%   79.96%   -0.80%     
==========================================
  Files          63       64       +1     
  Lines        4917     4957      +40     
==========================================
- Hits         3971     3964       -7     
- Misses        946      993      +47
Flag Coverage Δ
unittests 79.96% <78.41%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr changed the title Merge Develop to Master Merge Develop to Master, release v5.28.0 Feb 7, 2024
@alexskr alexskr merged commit 0423a45 into master Feb 7, 2024
4 checks passed
@jvendetti
Copy link
Member

The screenshot below was provided as an example of the notification that an ontology owner receives after a successful processing. The text of "Parsed successfully" directly followed by "Obsolete" is confusing, and I believe will generate traffic on our support list from users asking what this means. I object to releasing this in production without addressing this.

Screenshot 2024-02-09 at 11 35 39 AM

@alexskr
Copy link
Member Author

alexskr commented Feb 9, 2024 •
edited
Loading

obsolete submission status in the REST API is associated with determining obsolete classes and properties. Including this status in email notification can create some confusion so it should not be included in the email notification
..

@alexskr
Copy link
Member Author

alexskr commented Feb 9, 2024

The screenshot below was provided as an example of the notification that an ontology owner receives after a successful processing. The text of "Parsed successfully" directly followed by "Obsolete" is confusing, and I believe will generate traffic on our support list from users asking what this means. I object to releasing this in production without addressing this.

addressed by c77d0b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexskr @jvendetti @syphax-bouazzouni