forked from ontoportal/ontologies_linked_data
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Some lost code after submission refactoring PR and fix a bug the context language been empty #204
Merged
alexskr
merged 16 commits into
ncbo:feature/multilingual-support-add-search-and-languages-serialization
from
ontoportal-lirmm:pr/sync-agroportal-ncbo
May 21, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
changed the base branch from
develop
to
feature/multilingual-support-add-search-and-languages-serialization
May 18, 2024 18:01
…erialization' into pr/sync-agroportal-ncbo
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/multilingual-support-add-search-and-languages-serialization #204 +/- ##
=======================================================================================================
+ Coverage 78.10% 78.90% +0.79%
=======================================================================================================
Files 74 74
Lines 5372 5385 +13
=======================================================================================================
+ Hits 4196 4249 +53
+ Misses 1176 1136 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
syphax-bouazzouni
force-pushed
the
pr/sync-agroportal-ncbo
branch
from
May 20, 2024 18:53
7c5184f
to
67f9e10
Compare
…/ontologies_linked_data into pr/sync-agroportal-ncbo
syphax-bouazzouni
force-pushed
the
pr/sync-agroportal-ncbo
branch
from
May 20, 2024 19:29
67f9e10
to
f14a7eb
Compare
syphax-bouazzouni
changed the title
Fix: Some lost code after submission refactoring PR and a bug the context language been empty
Fix: Some lost code after submission refactoring PR and fix a bug the context language been empty
May 20, 2024
alexskr
merged commit May 21, 2024
112e39b
into
ncbo:feature/multilingual-support-add-search-and-languages-serialization
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix: serialization of properties using lambda as a property attribute #202 and add context parents generation tests (c83b0d5)
fix context language to not be empty array if submission language values are not URIs but just two letter strings (066c6c5)
Re-apply some remove code of the submission refactor
Complete metadata extraction test to close Missing unit test for IRI extraction #200 (ffc648f)
Do not send email notification when submissions are archived by @alexskr (b208745) and added a unit test for it (3b9d3f1) to close Notifications sends separate emails for archived status with vague content #190
include changes of Reapply previous pull requests and commits that were undone by PR #143 #203