Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Some lost code after submission refactoring PR and fix a bug the context language been empty #204

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented May 18, 2024

Changes

@syphax-bouazzouni syphax-bouazzouni changed the base branch from develop to master May 18, 2024 17:21
@syphax-bouazzouni syphax-bouazzouni changed the base branch from master to develop May 18, 2024 17:22
@syphax-bouazzouni syphax-bouazzouni changed the base branch from develop to feature/multilingual-support-add-search-and-languages-serialization May 18, 2024 18:01
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.90%. Comparing base (0227d37) to head (f14a7eb).

Files Patch % Lines
lib/ontologies_linked_data/serializers/json.rb 94.44% 1 Missing ⚠️
...ervices/submission_process/submission_processor.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                                           Coverage Diff                                           @@
##           feature/multilingual-support-add-search-and-languages-serialization     #204      +/-   ##
=======================================================================================================
+ Coverage                                                                78.10%   78.90%   +0.79%     
=======================================================================================================
  Files                                                                       74       74              
  Lines                                                                     5372     5385      +13     
=======================================================================================================
+ Hits                                                                      4196     4249      +53     
+ Misses                                                                    1176     1136      -40     
Flag Coverage Δ
unittests 78.90% <94.11%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…/ontologies_linked_data into pr/sync-agroportal-ncbo
@syphax-bouazzouni syphax-bouazzouni force-pushed the pr/sync-agroportal-ncbo branch from 67f9e10 to f14a7eb Compare May 20, 2024 19:29
@syphax-bouazzouni syphax-bouazzouni changed the title Fix: Some lost code after submission refactoring PR and a bug the context language been empty Fix: Some lost code after submission refactoring PR and fix a bug the context language been empty May 20, 2024
@alexskr alexskr merged commit 112e39b into ncbo:feature/multilingual-support-add-search-and-languages-serialization May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants