Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multilingual prefLabel(s) are captured incorrectly #229

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

mdorf
Copy link
Member

@mdorf mdorf commented Nov 21, 2024

This PR addresses #228
It requires a corresponding PR in the https://github.com/ncbo/ontologies_api project.

@mdorf mdorf changed the title Fix: #228 - Multilingual prefLabel(s) are captured incorrectly Fix: Multilingual prefLabel(s) are captured incorrectly Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (3aadf69) to head (0598b9f).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #229      +/-   ##
===========================================
- Coverage    81.08%   81.08%   -0.01%     
===========================================
  Files           74       74              
  Lines         5251     5250       -1     
===========================================
- Hits          4258     4257       -1     
  Misses         993      993              
Flag Coverage Δ
unittests 81.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@alexskr alexskr merged commit 6389fa2 into develop Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants