-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count atlas table viewers dynamically #714
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ee02dfc
to
ddd99af
Compare
@onursumer somehow we're missing
any clue what happened to each of these? |
ddd99af
to
7de20d8
Compare
|
Yes one of these is the BU cellxgene instance (you can see the URL by clicking on the production cellxgene link in the explore page): https://cellxgene.cziscience.com/d/BFAA0C46-7E34-4FA9-B08C-6DC6013B735A.cxg/. Don't think this one was ever fully harmonized/curated btw. Can you maybe check with Subhi what's going on here? She's been helping us curate/harmonize these files
This might be something @PozhidayevaDarya might be able to provide?
I see, yeah i also only see Joe Chan's dataset on their website: https://beta.xenabrowser.net/singlecell/?hub=https://previewsinglecell.xenahubs.net:443&defaultTable=htan. So seeing just 1 in your PR might be correct ☑️, maybe it was a manual typo from before
Ok cool, less worried about those. Your new implementation is prolly correct and there might've been a manual error before |
Fix #677
All counts are dynamically calculated by using the unfiltered files. cBioPortal counts are still hard-coded since we don't have that information as part of the data.