-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.6.1 #38
Release 4.6.1 #38
Conversation
Bumps [junit](https://github.com/junit-team/junit4) from 4.10 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.10.md) - [Commits](junit-team/junit4@r4.10...r4.13.1) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [gson](https://github.com/google/gson) from 2.3 to 2.8.9. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-2.3...gson-parent-2.8.9) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [gson](https://github.com/google/gson) from 2.3 to 2.8.9. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-2.3...gson-parent-2.8.9) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps jsch from 0.1.48 to 0.1.54. --- updated-dependencies: - dependency-name: com.jcraft:jsch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Main to develop to pickup 4.6.0 release
Bump junit from 4.10 to 4.13.1
…t-the-exception-when-reporting-scheduler-is-down Fixes 23 - added exception to log print statement
…om.google.code.gson-gson-2.8.9 Bump gson from 2.3 to 2.8.9 in /ncsa-common-incore
…com.google.code.gson-gson-2.8.9 Bump gson from 2.3 to 2.8.9 in /ncsa-common-clowder
…c/com.jcraft-jsch-0.1.54 Bump jsch from 0.1.48 to 0.1.54 in /datawolf-executor-hpc
…ess running tool (#31) * Fixes #28 - added the user/creator information to environment of process running the tool * Update datawolf-core/src/main/java/edu/illinois/ncsa/datawolf/Executor.java Co-authored-by: Rob Kooper <[email protected]>
…with latest API (#30) * Fixes #29 changed IN-CORE Dataset DAO and FileStorage implementation to use latest data service API * Updated command line executor and kubernetes executor based on changes to IN-CORE Dataset DAO and file storage * Updated how IN-CORE token is fetched and verify it exists before reading it * Verify file being deleted is in the temp directory space before calling delete
* upgrade hsql to 2.7.3
* Extra Variables added for INCORE specific * updated extraEnvVars as empty list so it can be expanded dynamically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at all the changes i think this is 4.7.0 and not just some changes to the helm chart.
make sure to remove the SNAPSHOT from all the poms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to release 4.7.0. Also updated pom.xml files by removing the SNAPSHOT. Why this happens? Is this automatic update? Also, I see some other version like 3.1.0-SNAPSHOT in other datawolf components, such as datawolf-excutor-commandline-ui or others. Should this also be updated to 4.7.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a maven build, you can create as many SNAPSHOT builds as you want; however, you can only push a single release so when we do a release, we remove SNAPSHOT and when we merge to main, this will push a release version (4.7.0).
You can ignore the 3.1.0-SNAPSHOT. They are no longer used or haven't been used in a long time and aren't part of the standard build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks for the explanation. If things look good. Let's get it merged and released so we can test datawolf in incore tst cluseter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, everything looks good. I didn't find any pom.xml files that need updating and CHANGELOG sets the release date/version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.