Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify the level of the posterior credible intervals for the phenometrics. #15

Merged
merged 7 commits into from
Feb 26, 2024

Conversation

mattshisler
Copy link
Collaborator

  • Added the cred_int_level parameter to the FitBLSP and FitBLSP_Spring functions with a default of 0.9 (90% credible interval)
  • Included an explanation in the function documentation and re-generated the documentation files using roxygen2.
  • Added a check to make sure the cred_int_value is between 0 and 1, exclusive.
  • Updated the BlspFit class to include the credible interval level used.
  • Updated the vis_fit function to label the produced plot with the credible interval level identified from the BlspFit object.
  • Updated vignette so that the changes are consistent with the displayed graphs and test data. I did not add any content explaining the new feature, however.

@mattshisler mattshisler requested a review from MrJGao February 23, 2024 16:28
@mattshisler
Copy link
Collaborator Author

Sorry, it looks like the entire vignette markdown is treated as "different" which is driving the 1,000+ deleted/added lines.

In reality I only updated the vignette markdown to reflect correctly labeled credible intervals in the plots.

@mattshisler
Copy link
Collaborator Author

Looks like it "diff"ed the entire mod_fit files as well.

@MrJGao MrJGao merged commit 677d473 into ncsuSEAL:main Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants