Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return value to sbt_revoke_by_owner #88

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Add return value to sbt_revoke_by_owner #88

merged 7 commits into from
Sep 25, 2023

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Sep 11, 2023 •
edited
Loading

  • add return value to sbt_revoke_by_owner informing if all the tokens were revoked or the method need to be called again
  • add unit test for it

@amityadav0
Copy link
Contributor

Could you please add what this is about ?

amityadav0
amityadav0 reviewed Sep 12, 2023
View reviewed changes
contracts/registry/src/registry.rs Outdated Show resolved Hide resolved
contracts/registry/src/lib.rs Show resolved Hide resolved
contracts/registry/src/registry.rs Outdated Show resolved Hide resolved
@sczembor sczembor marked this pull request as ready for review September 12, 2023 12:27
@sczembor sczembor requested a review from a team as a code owner September 12, 2023 12:27
@sczembor sczembor changed the title draft + unit test Add return value to sbt_revoke_by_owner Sep 12, 2023
robert-zaremba
robert-zaremba approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving.

contracts/registry/src/lib.rs Outdated Show resolved Hide resolved
contracts/registry/src/registry.rs Show resolved Hide resolved
contracts/registry/src/registry.rs Outdated Show resolved Hide resolved
contracts/registry/src/registry.rs Outdated Show resolved Hide resolved
@sczembor sczembor enabled auto-merge (squash) September 25, 2023 06:17
@sczembor sczembor merged commit cfc92b1 into master Sep 25, 2023
3 checks passed
@sczembor sczembor deleted the sbt_revoke_by_owner_return_value branch September 25, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amityadav0 amityadav0 amityadav0 left review comments

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sczembor @amityadav0 @robert-zaremba