Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement is_human_call_lock #96

Merged
merged 7 commits into from
Oct 31, 2023
Merged

implement is_human_call_lock #96

merged 7 commits into from
Oct 31, 2023

Conversation

robert-zaremba
Copy link
Contributor

This is needed for Voting Body personhood checks.

@robert-zaremba robert-zaremba requested a review from a team as a code owner October 30, 2023 18:00
Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets reuse the existing integration test for migration

Copy link
Contributor

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I was thinking about potential shortcomings which may be a dapp setting the lock duration to some crazy long time (let's say a couple of yeas) either by a code bug or on purpose. Maybe there should be a way to release the lock before. The easiest way would be some admin method that can be called or a way for the dapp that the lock comes from to release it (it might be also good for some use cases where the i.e voting ends earlier than expected and the lock can be released).

Left few code suggestions in code mostly docs and comments. Also the integration test for migration is missing

@robert-zaremba robert-zaremba enabled auto-merge (squash) October 31, 2023 08:58
@robert-zaremba robert-zaremba merged commit babd065 into master Oct 31, 2023
3 checks passed
@robert-zaremba robert-zaremba deleted the is_human_call_lock branch October 31, 2023 09:13
@robert-zaremba
Copy link
Contributor Author

I was thinking about potential shortcomings which may be a dapp setting the lock duration to some crazy long time (let's say a couple of yeas).

I will add a safety check to 2months.
However, we can't protect from a dapp proposing a user bad transactions. Examples:

  • transfer of fungible tokens or NFTs to unwanted account
  • soul transfer to some other account
  • deleting account ...
    If user won't read tx, he will be screwed anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants