[ENH] - Include "--attempt-fixes" flag from Nebari upgrade CLI in upgrade steps logic #2839
Conversation
smokestacklightnin
force-pushed
the
commands/upgrade/attempt-fix-logic
branch
4 times, most recently
from
2b5260e
to
d053d04
Compare
src/_nebari/upgrade.py
Outdated
| @@ -640,11 +685,11 @@ def _version_specific_upgrade( | |||
| "" | |||
| ) | |||
|
|
|||
| continue_ = Prompt.ask( | |||
| continue_ = attempt_fixes or Confirm.ask( | |||
There was a problem hiding this comment.
Is there a way to automate the deletion of Argo Workflow CRDs? Otherwise, we are just assuming that the deletion already took place if attempt_fixes == true.
The same type of question applies to more changes below in the upgrade.py.
There was a problem hiding this comment.
Yes, there is. @marcelovilla did it for the Prometheus operator upgrade. See
Line 1043 in 855aa14
There was a problem hiding this comment.
@smokestacklightnin did you see the approach I implemented? You'd need to add the logic to automatically delete the relevant CRDs here if the attempt_fixes is passed. We would need an extra step or we would need to reframe the question, though.
|
This should probably be a draft PR if you still have questions about the implementation |
smokestacklightnin
force-pushed
the
commands/upgrade/attempt-fix-logic
branch
from
d053d04
to
47df80c
Compare
src/_nebari/upgrade.py
Outdated
| @@ -640,11 +685,11 @@ def _version_specific_upgrade( | |||
| "" | |||
| ) | |||
|
|
|||
| continue_ = Prompt.ask( | |||
| continue_ = attempt_fixes or Confirm.ask( | |||
There was a problem hiding this comment.
@smokestacklightnin did you see the approach I implemented? You'd need to add the logic to automatically delete the relevant CRDs here if the attempt_fixes is passed. We would need an extra step or we would need to reframe the question, though.
|
@smokestacklightnin can you also make sure the tests are passing? |
…adeStep._version_specific_upgrade`
…ep.update_image_tag`
smokestacklightnin
force-pushed
the
commands/upgrade/attempt-fix-logic
branch
from
4807612
to
239c419
Compare
smokestacklightnin
force-pushed
the
commands/upgrade/attempt-fix-logic
branch
from
adade08
to
d7520ed
Compare
| for crd in argo_crds: | ||
| api_instance = kubernetes.client.ApiextensionsV1Api() | ||
| try: | ||
| api_instance.delete_custom_resource_definition( | ||
| name=crd, | ||
| ) | ||
| except kubernetes.client.exceptions.ApiException as e: | ||
| if e.status == 404: | ||
| rich.print(f"CRD [yellow]{crd}[/yellow] not found. Ignoring.") | ||
| else: | ||
| raise e | ||
| else: | ||
| rich.print(f"Successfully removed CRD [green]{crd}[/green]") | ||
|
|
||
| for sa in argo_sa: | ||
| api_instance = kubernetes.client.CoreV1Api() | ||
| try: | ||
| api_instance.delete_namespaced_service_account( | ||
| sa, | ||
| namespace, | ||
| ) | ||
| except kubernetes.client.exceptions.ApiException as e: | ||
| if e.status == 404: | ||
| rich.print( | ||
| f"Service account [yellow]{sa}[/yellow] not found. Ignoring." | ||
| ) | ||
| else: | ||
| raise e | ||
| else: | ||
| rich.print( | ||
| f"Successfully removed service account [green]{sa}[/green]" | ||
| ) |
There was a problem hiding this comment.
@marcelovilla I was able to adapt what you did
Reference Issues or PRs
This resloves #2761 by passing the
attempt_fixesvariable from the command line option to the upgrade methods.What does this implement/fix?
Put a
xin the boxes that applyTesting
How to test this PR?
Run
nebari upgrade --attempt-fixesand verify that the upgrade is successful without prompts from the user.Any other comments?