Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit setgid support to Rpm and Deb tasks #429

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Sep 6, 2023

With gradle 8.3 it is no longer possible to configure setgid via dirMode using 02000 permissions. This PR addresses this by introducing a dedicated property to enable setgid support. This issue is blocking our team (elasticsearch) to update to gradle 8.3. We tested this in our elasticsearch build already with a snapshots of this plugin using jitpack

see elastic/elasticsearch#97838

With gradle 8.3 it is not possible to configure setgid permissions via the dirMode property anymore.
Therefore we need a dedicated property in the packaging tasks to take this into account
@breskeby
Copy link
Contributor Author

Any chance we get this merged?

@rpalcolea rpalcolea merged commit 3149924 into nebula-plugins:main Sep 25, 2023
6 checks passed
@rpalcolea
Copy link
Member

Hi @breskeby!

first at all, sorry for the delay here, definitely fell through the cracks and thanks for the PR

I went ahead and release this under https://github.com/nebula-plugins/gradle-ospackage-plugin/releases/tag/v11.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants