Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log payloads that are skipped becuse no jobs were run #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iloveitaly
Copy link
Contributor

No description provided.

else
# TODO persist translation for audit trail?

log.info 'skipping payload, no jobs',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

skipped_job: job.class.to_s,
payload: payload,
payload_type: type,
payload_state: job.payload_state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iloveitaly What's that 😸 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Forgot to remove this. This relies on the Translation class

https://github.com/nebulab/cangaroo/pull/19/files#diff-45c84b17b9d53ae7c13d03d296304e38R27

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iloveitaly can you please remove it, we'll add it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants