-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] update Holochain-related client deps to latest versions #6
Conversation
…ate @holochain/client modules in build causing bundler issues
…l builds (maybe a broken resume feature?)
tests/package.json
Outdated
@@ -20,12 +20,11 @@ | |||
"uuidv4": "^6.2.11" | |||
}, | |||
"devDependencies": { | |||
"@holochain/client": "0.8.0", | |||
"@holochain/tryorama": "0.7.0", | |||
"@holochain/client": "^0.11.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it looks like 0.11.14 is meant for holochain beta-rc.3 (as per default.nix
on the tagged commit: https://github.com/holochain/holochain-client-js/blob/35a94fceda77335f14a694ef3a7e6a40e6a20980/default.nix#L4)
but it looks like 0.11.13
is for beta-rc.2: https://github.com/holochain/holochain-client-js/blob/cdcf8496811817f06d96cea471db90890602bd27/default.nix#L4
I'm actually not certain about how strict we need to be with the client versions and how semver is being used in the client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang it :p Sure, we should wind those back for now.
I'm actually not certain about how strict we need to be with the client versions and how semver is being used in the client.
I would recommend specifying ^0.11.13
and committing the workspace package lockfile. That should allow 0.11.14
to be used once we're ready to update whilst also preventing breakages due to semi-randomly selected "most recent versions" (package-lock.json
ensures that any devs will end up with identical packages rather than potentially varied ones).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(still to do: @pospi to organize lockfile)
@weswalla if you can't get it to not download 0.11.14 let me know and I can try to fix. I've never tried it before but I suspect that an npm i
on a clean repo will prefer the most recent compatible package from npm (.14) and I thought maybe hacking at package-lock.json
after generation to override that to .13 followed by wiping node_modules and another npm i
could get us what we want for this version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue is that there are breaking changes even when only the rightmost number changes, so if we don't pin an exact client version there may be imcompatibilities with imported modules that also depend on the client (like @neighbourhoods/nh-we-applet
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so for example, when this is on 0.11.13
then initializing SensemakerStore()
gives an error because @neighbourhoods/nh-we-applet
is on 0.11.9
, which I'm pretty sure is not following semver...
Like AppAgentWebsocket.connect()
, in 0.11.9 it is defined like so: https://github.com/holochain/holochain-client-js/blob/66d2e62f1d279f7e12ff6f41e67ad8eac606a55f/src/api/app-agent/websocket.ts#L77-L80
but in 0.11.13, like this: https://github.com/holochain/holochain-client-js/blob/cdcf8496811817f06d96cea471db90890602bd27/src/api/app-agent/websocket.ts#L80-L84
…lochain client 0.11.13
…date sensemaker-lite dna
…chronous 'full' renderer
…ecify holochain client 0.11.13" This reverts commit 8bf64b7.
…ng changes between 0.11.X versions
… time, to allow builds to be tested against development sandbox more easily
…ecking) Rollup plugin during watched build, fix wrong script path in UI index file
Fixes duplicate
@holochain/client
modules in build causing bundler issues with some other libraries, which is worthwhile doing regardless but will hopefully solve #5.I've taken the liberty of relaxing dependency specifiers to minver rather than exact versions. This should help to alleviate dependency issues now that upstream is in beta.
Needs more work that I'm not comfortable about proceeding with currently:
@holochain-open-dev/cell-client
appears to be deprecated and I'm unsure what to replace it withtests/src/provider.ts
potentially needs to be updated for any changes to Tryorama