Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incomplete information was passed to spooler regex #100

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

jitkang
Copy link
Contributor

@jitkang jitkang commented Nov 20, 2023

Hi @neilmunday, there was an issue parsing job information when spooling a new email if the job name contain comma symbol, for example 1,2-R-Triazole-Cu2+. Since comma is used as the delimiter to extract the information, the part after the comma in the job name will be missing after the split for the regex to capture the match. This problem does not occur with other symbol other than comma as far as I have tested.

I have adjusted the code to properly read the full job name so that the regex search can function properly. The code has been tested on slurm-v23.06.2 on both Array and non-Array jobs.

@jitkang jitkang requested a review from neilmunday as a code owner November 20, 2023 03:14
@neilmunday
Copy link
Owner

@jitkang thank you for this pull request.

Not sure how the incorrect variable use for build-tools/process-template.py made it through previous pylint runs - thanks for fixing.

I need to double check why the split on the comma was put in.

@neilmunday neilmunday self-assigned this Nov 20, 2023
@neilmunday neilmunday added the bug Something isn't working label Nov 20, 2023
@neilmunday neilmunday added this to the 4.7 milestone Nov 20, 2023
@neilmunday neilmunday changed the base branch from main to 4.7 November 20, 2023 21:40
@neilmunday
Copy link
Owner

Code changes look good, merging into 4.7 branch.

@neilmunday neilmunday merged commit b5dda50 into neilmunday:4.7 Nov 20, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants