Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Admin Comment field to Job Information Table #101

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

jitkang
Copy link
Contributor

@jitkang jitkang commented Nov 21, 2023

Starting SLURM v22.x release, they added a new Admin Comment field in additional to Comment field, which is only modifiable by Administrator. This is can be useful for Administrator to pass job information to users through the email by setting AdminComment via scontrol command.

Although this might not be useful for everyone, I think it would be a good additional for its usefulness and convenience.

The pull request add the additional field extraction and parsing, and only display the information in the job table after the job end.

@jitkang jitkang requested a review from neilmunday as a code owner November 21, 2023 01:09
@jitkang
Copy link
Contributor Author

jitkang commented Nov 21, 2023

I have added an additional empty field column for AdminComment in the tests so that it doesn't fail.

@neilmunday neilmunday self-assigned this Nov 21, 2023
@neilmunday neilmunday added the enhancement New feature or request label Nov 21, 2023
@neilmunday neilmunday added this to the 4.7 milestone Nov 21, 2023
@neilmunday
Copy link
Owner

Thanks for this modification, merging into 4.7 branch.

@neilmunday neilmunday merged commit 3b414d4 into neilmunday:4.7 Nov 21, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants