Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cms: remove the use of KeyWrap, use Kek directly #4

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

baloo
Copy link

@baloo baloo commented Nov 6, 2024

This brings a merge of origin/master because const-oid got bumped, ideally the whole branch needs a rebase.

Only the last commit is required here.

@baloo
Copy link
Author

baloo commented Nov 6, 2024

the merge is required because of the const-oid version requirement that RustCrypto/key-wraps#39 brings.

@nemynm
Copy link
Owner

nemynm commented Nov 9, 2024

I think key-wraps crate got some re-factoring that changed its API yesterday, should I just recreate a clean feature branch?

@baloo
Copy link
Author

baloo commented Nov 10, 2024

yeah that moved yesterday morning. I'll update that branch.

@baloo baloo force-pushed the keywrap-trait branch 2 times, most recently from 58bc8ef to fb63743 Compare November 10, 2024 04:37
@nemynm
Copy link
Owner

nemynm commented Nov 15, 2024

Should we update for latest aes-kw changes here or merge and do it after?

@baloo
Copy link
Author

baloo commented Nov 15, 2024

We can do that here, but it'd be nice if you could rebase the keywrap-trait branch

@nemynm
Copy link
Owner

nemynm commented Nov 15, 2024

We can do that here, but it'd be nice if you could rebase the keywrap-trait branch

sure I'll do it, favor "rebase" rebase or "merge" rebase?

@baloo
Copy link
Author

baloo commented Nov 15, 2024

I meant rebase rebase

@nemynm
Copy link
Owner

nemynm commented Nov 16, 2024

Rebase it is!

@baloo baloo marked this pull request as draft November 17, 2024 03:34
@baloo baloo marked this pull request as ready for review November 17, 2024 05:44
@nemynm nemynm merged commit 6717a8e into nemynm:keywrap-trait Nov 17, 2024
165 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants