Fix Place block. #116
Fix Place block. #116
Conversation
There was a problem hiding this comment.
Good find! A bug as clear as it can be.
One comment about something apparently unrelated.
And maybe you can fix the warning in the github actions check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
| @@ -753,7 +753,7 @@ def choices(self): | |||
|
|
|||
| @staticmethod | |||
| def process(source, *choices): | |||
| result = pd.Series(np.nan, index=source.index) | |||
| result = pd.Series(np.nan, dtype=object, index=source.index) | |||
There was a problem hiding this comment.
Why did you touch this?
I guess it originally was float; reading the docstring I think this geoblock is also intended for numbers. Changing it to object will allow any type, also strings, is that what something you intend to fix? For floats and ints this will be a suboptimal efficiency...
There was a problem hiding this comment.
FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas. Value '['A']' has dtype incompatible with float64, please explicitly cast to a compatible dtype first.
I used this solution from the other open PR, it solves the warning and I didn't dive into it further.
There was a problem hiding this comment.
I fixed the rtd action somehow, but I don't know where to find the warning that you mention. I will merge for now and then we move on.
|
@caspervdw Care to make a release now this is merged? |
|
Thanks for the reminder, it's done now |
When fixing a transform performance issue, a swap of xmax and ymin was inadvertently introduced (difference between ogrs "Envelope" and the bbox the rest of the world uses). This had some consequences: