fix: selfish mining

[Jim8y]

neo-project/neo#2918

Prevents:

• Primary starts consensus early.
• Primary starts consensus early but with a future timestamp.

[vncoelho]

@Liaojinghui ,what exactly are you trying to solve and when it happens?

I see the code and saw some blockIndex and 10000 as a value of the if. Why using block index?

[Jim8y]

The problem here is that malicious nodes can start the consensus early when they become the primary, speeding up the consensus and thus generating more blocks and mining more GAS. We did not check a thing that is similar to mining difficulty. As v17 has mentioned here neo-project/neo#2918, this is not an emergency fix, it is totally OK, it you think consensus nodes should be allowed to speed up the consensus maliciously.

I use 10000 just because i need a time window to konw what is the average block time in the past 10000 blocks, if they are shoter than the default consensus time, then the current consensus round would wait longer to slow down the consensus.

[shargon]

Create a new method IsValidTimestamp(previous, current) with UT?

[Jim8y]

Create a new method IsValidTimestamp(previous, current) with UT?

would be challenging to have 10000 blocks UT, LOL, lets find out.

[cschuchardt88]

One way, is to use NeoSystem in memory, than you could sleep thread until height is 10k. Should download on network and should be quick.

[Jim8y]

Kinda fun when i set it to 10000, not anymore.