-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpCode Benchmark] add benchmark files #3528
base: HF_Echidna
Are you sure you want to change the base?
Conversation
Gooood job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see anything beneficial if none of them contain a valid test, lots of classes that do nothing are not worth much (in my opinion)
@shargon we are working on benchmarking all of them, creating them one by one is unnecessary so I use script to create all of the files since we will otherwise create them one by one. This is benchmark, please dont use core-standard to review them. |
I do empty files for
|
I will fill those files with basic one opcode tests to make sure it is effective. |
Ok, i will approve it when it's reqdy to review |
Many instructions require some setup before they can be tested, so in its current form this doesn't make much sense. Better merge real tests instruction after instruction (more likely sets of those). |
…ange. and add hardfork
# Conflicts: # benchmarks/Neo.VM.Benchmarks/InstructionBuilder/InstructionBuilder.cs # benchmarks/Neo.VM.Benchmarks/OpCode/Arrays/OpCode.ReverseN.cs # benchmarks/Neo.VM.Benchmarks/OpCode/Benchmark.Opcode.cs # benchmarks/Neo.VM.Benchmarks/OpCode/BenchmarkEngine.cs # benchmarks/Neo.VM.Benchmarks/OpCode/OpCodeBase.cs # benchmarks/Neo.VM.Benchmarks/VMTypes/Benchmarks_Convert.cs
# Conflicts: # benchmarks/Neo.VM.Benchmarks/Benchmarks.POC.cs # benchmarks/Neo.VM.Benchmarks/Program.cs
Description
This pr adds opcode benchmark files to ease the further work.
Fixes #
Type of change
Checklist: