Merge pull request #560 from neo4j-labs/develop

Release 2.3.2
neo4j-labs · Aug 14, 2023 · b8d4657 · b8d4657
2 parents c34adf5 + 6e15d27
commit b8d4657
Show file tree

Hide file tree

Showing 89 changed files with 1,957 additions and 1,638 deletions.
diff --git a/.github/workflows/master-deployment.yml b/.github/workflows/master-deployment.yml
@@ -79,7 +79,7 @@ jobs:
           context: .
           file: ./Dockerfile
           push: true
-          tags: ${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:2.3.1
+          tags: ${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:2.3.2
   build-docker-legacy:
     needs: build-test
     runs-on: ubuntu-latest
@@ -103,7 +103,7 @@ jobs:
           context: .
           file: ./Dockerfile
           push: true
-          tags: ${{ secrets.DOCKER_HUB_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_USERNAME }}/neodash:2.3.1
+          tags: ${{ secrets.DOCKER_HUB_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_USERNAME }}/neodash:2.3.2
   deploy-gallery:
     runs-on: ubuntu-latest
     strategy:

diff --git a/.gitignore b/.gitignore
@@ -37,4 +37,6 @@ node_modules
 jspm_packages
 
 # Serverless directories
-.serverless
+.serverless
+# Sentry Auth Token
+.env.sentry-build-plugin
diff --git a/Dockerfile b/Dockerfile
@@ -43,4 +43,4 @@ USER nginx
 EXPOSE $NGINX_PORT
 
 HEALTHCHECK cmd curl --fail "http://localhost:$NGINX_PORT" || exit 1
-LABEL version="2.3.1"
+LABEL version="2.3.2"
diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,21 @@
+## NeoDash 2.3.2
+What's new in NeoDash 2.3.2? A few bug fixes, performance improvements and more important, it ships phase 2 of our migration to [Needle](https://neo4j.com/developer-blog/needle-neo4j-design-system/)  !
+
+- Key Features:
+  - UI updated to use the **[Neo4j Design Language](https://www.neo4j.design/)** phase 2, giving NeoDash a similar look-and-feel to other Neo4j tools. This includes the removal of the sidebar and a complete refactor on the header component. ([@mariusconjeaud](https://github.com/mariusconjeaud),[@konsalex](https://github.com/konsalex),[@BennuFire](https://github.com/bennufire), [#552](https://github.com/neo4j-labs/neodash/pull/552))
+  - *Experimental* Support for **Dark Mode**.
+- Parameter Selector Chart
+  - New advanced setting 'Manual Parameter Save' allowing  dashboard parameters propagation on demand (instead of automatically on change) ([@BennuFire](https://github.com/bennufire), [#545](https://github.com/neo4j-labs/neodash/pull/545))
+  - Fix delete button leading to inconsistent values on click. ([@BennuFire](https://github.com/bennufire), [#545](https://github.com/neo4j-labs/neodash/pull/545))
+
+  - Fix search on numbers not being triggered. ([@BennuFire](https://github.com/bennufire), [#545](https://github.com/neo4j-labs/neodash/pull/545))
+
+- Others
+  - Fix performance degradation on schema calculation ([@BennuFire](https://github.com/bennufire), [#555](https://github.com/neo4j-labs/neodash/pull/555))
+  - Fix standalone bug that prevent user from using username and password fields([@BennuFire](https://github.com/bennufire), [#551](https://github.com/neo4j-labs/neodash/pull/551))
+  - Added Sentry Support on https://neodash.graphapp.io ([@mariusconjeaud](https://github.com/mariusconjeaud), [#546](https://github.com/neo4j-labs/neodash/pull/546))
+  - Fix SSO redirection on editor mode ([@BennuFire](https://github.com/bennufire), [#543](https://github.com/neo4j-labs/neodash/pull/543))
+
 ## NeoDash 2.3.1
 What's new in NeoDash 2.3.1? A few bug fixes, improvement of natural language queries with support of Azure Open AI and parameters, Graph Vizualization relationship styling and more below!
 

diff --git a/cypress.config.ts b/cypress.config.ts
@@ -5,10 +5,16 @@ export default defineConfig({
   projectId: 'a8nh14',
   video: false,
   e2e: {
+    experimentalMemoryManagement: true,
+    numTestsKeptInMemory: 0,
     baseUrl: 'http://localhost:3000',
     setupNodeEvents(on, config) {
       return require('./cypress/plugins/index.js')(on, config);
     },
+    retries: {
+      runMode: 2,
+      openMode: 0,
+    },
   },
   env: {
     codeCoverage: {

diff --git a/cypress/e2e/start_page.cy.js b/cypress/e2e/start_page.cy.js
@@ -27,7 +27,7 @@ describe('NeoDash E2E Tests', () => {
       },
     });
 
-    cy.get('#form-dialog-title', { timeout: 2000 }).should('be.visible');
+    cy.get('#form-dialog-title', { timeout: 20000 }).should('contain', 'NeoDash - Neo4j Dashboard Builder').click();
 
     cy.get('#form-dialog-title').then(($div) => {
       const text = $div.text();
@@ -43,7 +43,7 @@ describe('NeoDash E2E Tests', () => {
     //     cy.contains('Yes').click()
     // }
 
-    cy.get('#form-dialog-title').should('contain', 'Connect to Neo4j');
+    cy.get('#form-dialog-title', { timeout: 20000 }).should('contain', 'Connect to Neo4j');
 
     // Connect to Neo4j database
     // cy.get('#protocol').click()
@@ -279,6 +279,7 @@ describe('NeoDash E2E Tests', () => {
 });
 
 function enableAdvancedVisualizations() {
+  cy.get('main button[aria-label="Dashboard actions').should('be.visible').click();
   cy.get('#extensions-sidebar-button').should('be.visible').click();
   cy.get('#checkbox-advanced-charts').should('be.visible').click();
   cy.get('.ndl-dialog-close').scrollIntoView().should('be.visible').click();
@@ -321,6 +322,9 @@ function checkInitialState() {
 
 function createCard() {
   // Check the starter cards
-  cy.get('main .react-grid-item:eq(2)  button[aria-label="add report"]').click();
+  cy.get('main .react-grid-item button[aria-label="add report"]', { timeout: WAITING_TIME })
+    .should('be.visible')
+    .click();
+  cy.wait(1000);
   cy.get('main .react-grid-item:eq(2)').should('contain', 'No query specified.');
 }
diff --git a/cypress/plugins/index.js b/cypress/plugins/index.js
@@ -2,5 +2,12 @@ module.exports = (on, config) => {
   require('@cypress/code-coverage/task')(on, config);
   //Used to instrument code ran like unit tests
   on('file:preprocessor', require('@cypress/code-coverage/use-babelrc'));
+  on('before:browser:launch', (browser, launchOptions) => {
+    if (browser.family === 'chromium') {
+      console.log('Adding Chrome flag: --disable-dev-shm-usage');
+      launchOptions.args.push('--disable-dev-shm-usage');
+    }
+    return launchOptions;
+  });
   return config;
 };
diff --git a/docs/modules/ROOT/nav.adoc b/docs/modules/ROOT/nav.adoc
@@ -38,6 +38,7 @@
 ** xref:developer-guide/standalone-mode.adoc[Standalone Mode]
 ** xref:developer-guide/component-overview.adoc[Component Overview]
 ** xref:developer-guide/design.adoc[Design]
+** xref:developer-guide/style-configuration.adoc[Style Configuration]
 ** xref:developer-guide/adding-visualizations.adoc[Adding Visualizations]
 ** xref:developer-guide/state-management.adoc[State Management]
 ** xref:developer-guide/session-storage.adoc[Session Storage]

diff --git a/docs/modules/ROOT/pages/developer-guide/deploy-a-build.adoc b/docs/modules/ROOT/pages/developer-guide/deploy-a-build.adoc
@@ -37,7 +37,7 @@ Depending on the webserver type and version, this could be different directory.
 As an example - to copy the files to an nginx webserver using `scp`:
 
 ```bash
-scp neodash-2.3.1 username@host:/usr/share/nginx/html
+scp neodash-2.3.2 username@host:/usr/share/nginx/html
 ```
 
 NeoDash should now be visible by visiting your (sub)domain in the browser.

diff --git a/docs/modules/ROOT/pages/developer-guide/index.adoc b/docs/modules/ROOT/pages/developer-guide/index.adoc
@@ -6,7 +6,8 @@ This guide contains information for developers looking to deploy NeoDash, or ext
 - link:configuration[Configuration]
 - link:standalone-mode[Standalone Mode] 
 - link:component-overview[Component Overview] 
-- link:design[Design] 
+- link:design[Design]
+- link:style-configuration[Style Configuration]
 - link:adding-visualizations[Adding Visualizations] 
 - link:state-management[State Management] 
 - link:testing[Testing]

diff --git a/...s/developer-guide/styleConfiguration.adoc → .../developer-guide/style-configuration.adoc b/...s/developer-guide/styleConfiguration.adoc → .../developer-guide/style-configuration.adoc
@@ -14,7 +14,6 @@ An example configuration for NeoDash
 ....
 {
   "DASHBOARD_HEADER_BRAND_LOGO": "logo_lightsand.png",
-  "APPLY_CUSTOM_BRAND_LOGO": true,
   "DASHBOARD_HEADER_COLOR" : "#F3F3F0",
   "DASHBOARD_HEADER_BUTTON_COLOR" : "#009999",
   "DASHBOARD_HEADER_TITLE_COLOR" : "#00C1B6",
@@ -31,9 +30,7 @@ An example configuration for NeoDash
 [width="100%",cols="19%,17%,26%,38%",options="header",]
 |===
 |Name |Type |Default Value |Description
-|APPLY_CUSTOM_BRAND_LOGO |boolean |false |If enabled, a custom logo will be used on the header based on the DASHBOARD_HEADER_BRAND_LOGO variable.
-
-|DASHBOARD_HEADER_BRAND_LOGO |string |undefined |If APPLY_CUSTOM_BRAND_LOGO is true, this variable defines the name of the logo file located on the public folder of the Neodash deployment.
+|DASHBOARD_HEADER_BRAND_LOGO |string |undefined |This variable defines the name of the logo file located on the public folder of the Neodash deployment, if you want your own logo instead of the Neo4j one.
 
 |DASHBOARD_HEADER_COLOR |string |#0B297D |Determines the color of the header.
 

diff --git a/docs/modules/ROOT/pages/user-guide/reports/parameter-select.adoc b/docs/modules/ROOT/pages/user-guide/reports/parameter-select.adoc
@@ -55,6 +55,10 @@ global parameter completely when the field is cleared. This may break
 some visualizations. If disabled, sets the parameter value to “” (empty
 string) when the input field is cleared.
 
+|Multiple Selection |on/off |off |If enabled, allows user to select multiple choices. Parameter will be then an array of selections.
+
+|Manual Parameter Save |on/off |off |If enabled, adds a confirmation button in order to propagate the selection into the dashboard parameter.
+
 |Enable Manual Label/Property Name Specification |on/off |off |If
 enabled, does not enforce you to select a node label/property using an
 auto-complete field, instead, you can enter any value. This is useful

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "neodash",
-  "version": "2.3.1",
+  "version": "2.3.2",
   "description": "NeoDash - Neo4j Dashboard Builder",
   "neo4jDesktop": {
     "apiVersion": "^1.2.0"
@@ -36,27 +36,29 @@
   "dependencies": {
     "@azure/openai": "^1.0.0-beta.2",
     "@codemirror/lang-markdown": "^6.1.1",
-    "@codemirror/language-data": "^6.3.1",
+    "@dnd-kit/core": "^6.0.8",
+    "@dnd-kit/sortable": "^7.0.2",
     "@mui/icons-material": "^5.11.16",
     "@mui/material": "^5.12.3",
     "@mui/styles": "^5.12.3",
     "@mui/x-data-grid": "5.17.26",
     "@mui/x-date-pickers": "^5.0.17",
-    "@neo4j-cypher/react-codemirror": "^1.0.2",
-    "@neo4j-ndl/base": "1.7.0",
-    "@neo4j-ndl/react": "1.7.0",
-    "@nivo/bar": "^0.82.1",
-    "@nivo/circle-packing": "^0.82.1",
-    "@nivo/core": "^0.82.1",
-    "@nivo/geo": "^0.82.1",
-    "@nivo/line": "^0.82.1",
-    "@nivo/pie": "^0.82.1",
-    "@nivo/radar": "^0.82.1",
-    "@nivo/sankey": "^0.82.1",
+    "@neo4j-cypher/react-codemirror": "^1.0.3",
+    "@neo4j-ndl/base": "1.10.1",
+    "@neo4j-ndl/react": "1.10.2",
+    "@nivo/bar": "^0.83.0",
+    "@nivo/circle-packing": "^0.83.0",
+    "@nivo/core": "^0.83.0",
+    "@nivo/geo": "^0.83.0",
+    "@nivo/line": "^0.83.0",
+    "@nivo/pie": "^0.83.0",
+    "@nivo/radar": "^0.83.0",
+    "@nivo/sankey": "^0.83.0",
     "@nivo/scatterplot": "^0.83.0",
-    "@nivo/sunburst": "^0.82.1",
-    "@nivo/treemap": "^0.82.1",
+    "@nivo/sunburst": "^0.83.0",
+    "@nivo/treemap": "^0.83.0",
     "@sentry/react": "^7.57.0",
+    "@sentry/webpack-plugin": "^2.5.0",
     "babel-runtime": "^6.26.0",
     "chroma-js": "^2.4.2",
     "classnames": "^2.3.1",
@@ -87,6 +89,7 @@
     "react-markdown": "^8.0.0",
     "react-redux": "^7.2.6",
     "react-show-more-text": "^1.6.2",
+    "react-toggle-dark-mode": "^1.1.1",
     "react-use-error-boundary": "^3.0.0",
     "redux-persist": "^6.0.0",
     "redux-thunk": "^2.4.1",

diff --git a/public/neo4j-icon-color-full.png b/public/neo4j-icon-color-full.png
diff --git a/release-notes.md b/release-notes.md
@@ -1,21 +1,17 @@
-## NeoDash 2.3.1
-What's new in NeoDash 2.3.1? A few bug fixes, improvement of natural language queries with support of Azure Open AI and parameters, Graph Vizualization relationship styling and more below!
+## NeoDash 2.3.2
+What's new in NeoDash 2.3.2? A few bug fixes, performance improvements and more important, it ships phase 2 of our migration to [Needle](https://neo4j.com/developer-blog/needle-neo4j-design-system/)  !
 
-- Natural language queries
-  - **Support of Azure Open AI** ([@BennuFire](https://github.com/bennufire), [#515](https://github.com/neo4j-labs/neodash/pull/515))
-  - Support parameters on natural language queries ([@BennuFire](https://github.com/bennufire), [#514](https://github.com/neo4j-labs/neodash/pull/514))
+- Key Features:
+  - UI updated to use the **[Neo4j Design Language](https://www.neo4j.design/)** phase 2, giving NeoDash a similar look-and-feel to other Neo4j tools. This includes the removal of the sidebar and a complete refactor on the header component. ([@mariusconjeaud](https://github.com/mariusconjeaud),[@konsalex](https://github.com/konsalex),[@BennuFire](https://github.com/bennufire), [#552](https://github.com/neo4j-labs/neodash/pull/552))
+  - *Experimental* Support for **Dark Mode**. 
+- Parameter Selector Chart
+  - New advanced setting 'Manual Parameter Save' allowing  dashboard parameters propagation on demand (instead of automatically on change) ([@BennuFire](https://github.com/bennufire), [#545](https://github.com/neo4j-labs/neodash/pull/545))
+  - Fix delete button leading to inconsistent values on click. ([@BennuFire](https://github.com/bennufire), [#545](https://github.com/neo4j-labs/neodash/pull/545))
+  - Fix search on numbers not being triggered. ([@BennuFire](https://github.com/bennufire), [#545](https://github.com/neo4j-labs/neodash/pull/545))
 
-- Graph Visualization
-  - Added styling rules for relationship color ([@brahmprakashMishra](https://github.com/brahmprakashMishra) [@BennuFire](https://github.com/bennufire), [#537](https://github.com/neo4j-labs/neodash/pull/537))
-
-- Table Chart
-  - Update TableChart to use first returned row values as titles when transposed ([@bastienhubert](https://github.com/bastienhubert), [#513](https://github.com/neo4j-labs/neodash/pull/513))
-  - Fix falsy boolean display on table ([@bastienhubert](https://github.com/bastienhubert), [#536](https://github.com/neo4j-labs/neodash/pull/536))
-
-- Report Actions
-  - Fix on Style and Action modal that was preventing from setting params on low resolutions ([@mariusconjeaud](https://github.com/mariusconjeaud), [#533](https://github.com/neo4j-labs/neodash/pull/533))
 
 - Others
-  - New setting for parameters selector to allow selection of multiple values instead of one + Fix multi selector on dates ([@BennuFire](https://github.com/bennufire), [#535](https://github.com/neo4j-labs/neodash/pull/535))
-  - Fix bug where protocol was not set properly on share links ([@nielsdejong](https://github.com/nielsdejong), [#521](https://github.com/neo4j-labs/neodash/pull/521))
-  - Update word-wrap from 1.2.3 to 1.2.4 ([@BennuFire](https://github.com/bennufire), [#526](https://github.com/neo4j-labs/neodash/pull/526) [#527](https://github.com/neo4j-labs/neodash/pull/527))
+  - Fix performance degradation on schema calculation ([@BennuFire](https://github.com/bennufire), [#555](https://github.com/neo4j-labs/neodash/pull/555))
+  - Fix standalone bug that prevent user from using username and password fields([@BennuFire](https://github.com/bennufire), [#551](https://github.com/neo4j-labs/neodash/pull/551))
+  - Added Sentry Support on https://neodash.graphapp.io ([@mariusconjeaud](https://github.com/mariusconjeaud), [#546](https://github.com/neo4j-labs/neodash/pull/546))
+  - Fix SSO redirection on editor mode ([@BennuFire](https://github.com/bennufire), [#543](https://github.com/neo4j-labs/neodash/pull/543))