Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.21.2 #178

Merged
merged 44 commits into from
Nov 15, 2024
Merged

Update to 1.21.2 #178

merged 44 commits into from
Nov 15, 2024

Conversation

ChampionAsh5357
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 commented Oct 14, 2024 •
edited
Loading

Applies the contribution formatting and updates the docs to 1.21.2. This is a separate section due to the large number of changes between versions.

Waiting On

Relevant Issues

Closes #177
Closes #179
Closes #180
Closes #181
Closes #183
Closes #196
Supersedes #174

Subsections

  • Advanced
  • Block Entities
  • Blocks
  • Concepts
  • Data Storage
  • Getting Started
  • GUI
  • Items
  • Legacy
  • Misc
  • Networking
  • Resources
    • Client
      • Models
    • Server
      • Data Maps
      • Enchantments
      • Loot Tables
      • Recipes
  • World Generation

Preview URL: https://pr-178.neoforged-docs-previews.pages.dev

@ChampionAsh5357 ChampionAsh5357 added update Previously correct, but now outdated information. large Major additions or changes. labels Oct 14, 2024
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 14, 2024 16:47 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Oct 14, 2024 •
edited
Loading

Deploying with Cloudflare Pages

Name Result
Last commit: 49804541f492b16f42cfb07f934d307be98417d9
Status: ✅ Deploy successful!
Preview URL: https://4f485fc7.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-178.neoforged-docs-previews.pages.dev

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 14, 2024 17:28 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 14, 2024 17:44 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 14, 2024 18:16 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 14, 2024 18:19 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 14, 2024 18:28 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 15, 2024 16:04 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 15, 2024 16:13 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 15, 2024 17:13 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 15, 2024 17:26 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 15, 2024 17:48 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 17, 2024 01:40 Active
XFactHD
XFactHD requested changes Nov 12, 2024
View reviewed changes
docs/advanced/extensibleenums.md Outdated Show resolved Hide resolved
docs/blockentities/index.md Outdated Show resolved Hide resolved
docs/blocks/index.md Outdated Show resolved Hide resolved
docs/items/interactionpipeline.md Outdated Show resolved Hide resolved
docs/resources/server/enchantments/index.md Outdated Show resolved Hide resolved
docs/resources/server/recipes/index.md Outdated Show resolved Hide resolved
docs/resources/server/recipes/custom.md Outdated Show resolved Hide resolved
docs/resources/server/recipes/custom.md Outdated Show resolved Hide resolved
docs/resources/server/recipes/custom.md Outdated Show resolved Hide resolved
docs/resources/server/recipes/custom.md Outdated Show resolved Hide resolved
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 12, 2024 03:08 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 12, 2024 03:47 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 12, 2024 20:59 Active
XFactHD
XFactHD previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@XFactHD XFactHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Just a couple comments from TG remaining unresolved.

@ChampionAsh5357
Copy link
Contributor Author

I have resolved everything I plan to implement in this PR. Anything else I'm leaving out for a separate PR.

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 13, 2024 04:18 Active
XFactHD
XFactHD previously approved these changes Nov 14, 2024
View reviewed changes
IchHabeHunger54
IchHabeHunger54 requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things I noticed, should be good to go otherwise.

docs/resources/server/recipes/index.md Outdated Show resolved Hide resolved
docs/resources/server/recipes/custom.md Outdated Show resolved Hide resolved
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) November 14, 2024 17:14 Active
@IchHabeHunger54 IchHabeHunger54 mentioned this pull request Nov 14, 2024
Merged
@IchHabeHunger54 IchHabeHunger54 merged commit 6130eef into neoforged:main Nov 15, 2024
1 check passed
This was referenced Nov 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TelepathicGrunt TelepathicGrunt TelepathicGrunt left review comments

@IchHabeHunger54 IchHabeHunger54 IchHabeHunger54 approved these changes

@XFactHD XFactHD XFactHD approved these changes

Assignees
No one assigned
Labels
large Major additions or changes. update Previously correct, but now outdated information.
Projects
None yet
Milestone
No milestone
4 participants
@ChampionAsh5357 @XFactHD @TelepathicGrunt @IchHabeHunger54