Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation for NeoForged and NeoGradle documentation #18

Closed
wants to merge 3 commits into from

Conversation

srcres258
Copy link
Contributor

@srcres258 srcres258 commented Oct 8, 2023

Add Chinese translation for NeoForged and NeoGradle documentation to make convenience for developers in China's Minecraft mod community.


Preview URL: https://pr-18.neoforged-docs-previews.pages.dev

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) October 8, 2023 11:10 Active
@neoforged-pages-deployments
Copy link

Deploying with Cloudflare Pages

Name Result
Last commit: e6ac0d4b0161e9a4a62cec35c1fbf422e667ccd9
Status: ✅ Deploy successful!
Preview URL: https://0c7c5f18.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-18.neoforged-docs-previews.pages.dev

…Gradle Documentation (FG6)

Signed-off-by: src_resources <[email protected]>
@ChampionAsh5357
Copy link
Contributor

Thank you for your work on the translation!

Apologies, but we currently don't have a team in place to review this PR with any degree of accuracy or the ability to maintain if it gets merged. We could use a translation app, but we would prefer having native speakers review PRs for accuracy.

As a heads up, until the teams and proper structure are in place, this PR likely won't be reviewed. Until then, you are welcome to keep translating.

…Gradle Documentation (FG5)

Signed-off-by: src_resources <[email protected]>
@srcres258
Copy link
Contributor Author

srcres258 commented Oct 8, 2023

Apologies, but we currently don't have a team in place to review this PR with any degree of accuracy or the ability to maintain if it gets merged. We could use a translation app, but we would prefer having native speakers review PRs for accuracy.

It doesn't matter. I'll keep this PR as a draft until reviewing process is available.

Btw, providing that there's no spare time for your team to carry out reviewing tasks, the translations would be kept in my source tree and I'll release them to the Chinese community ahead to both avoid wasting your energy on the scrutiny and gathering advice on improving these translations to obtain ideas from the native speakers as well.

@Mysterious-Dev
Copy link
Contributor

Maybe we can set up a Crowdin for translations of the documentation (and maybe the website).This would allow NeoForge projects to be translated with a more “user-friendly” interface.

@ChampionAsh5357
Copy link
Contributor

The changes in Crowdin's API makes it no longer suitable for the needs of NeoForge, so we are currently looking into other systems.

@Matyrobbrt
Copy link
Member

I would also argue that such systems aren't suitable for translating documentation, as documentation involves markdown, examples, and code comments. The best way of translating the docs is by translating the entire pages in an editor such as VSCode. More so, it would be harder to preview and update the translations in bulk if they're external to the repository.

On that note, this PR should organize the translations as explained in the Docusarus docs.

@srcres258
Copy link
Contributor Author

On that note, this PR should organize the translations as explained in the Docusarus docs.

OK, I'll reorganise the translations according to the standard mentioned.

@srcres258
Copy link
Contributor Author

Rewritten in PR #19.

@srcres258 srcres258 closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants