Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"IItemstackExtension#onEntitySwing" method should take "InteractionHand" as a parameter #1497

Closed
KodYazanDruid opened this issue Aug 29, 2024 · 1 comment · Fixed by #1499
Closed

"IItemstackExtension#onEntitySwing" method should take "InteractionHand" as a parameter #1497

KodYazanDruid opened this issue Aug 29, 2024 · 1 comment · Fixed by #1499
Labels
1.21.1 Targeted at Minecraft 1.21.1 enhancement New (or improvement to existing) feature or request

Comments

@KodYazanDruid
Copy link

"LivingEntity#swing" calls this method and does not pass InteractionHand as a parameter because it did not receive update when hands added. (sci said so :P)
@KodYazanDruid KodYazanDruid added the enhancement New (or improvement to existing) feature or request label Aug 29, 2024
@sciwhiz12 sciwhiz12 added the 1.21.1 Targeted at Minecraft 1.21.1 label Aug 29, 2024
@ApexModder ApexModder mentioned this issue Aug 29, 2024
Merged
@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.1.41, as part of #1499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21.1 Targeted at Minecraft 1.21.1 enhancement New (or improvement to existing) feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[21.1] Pass along interaction had to ItemStack.onEntitySwing ApexModder/NeoForge
2 participants
@sciwhiz12 @KodYazanDruid