Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.1] Pass along interaction had to ItemStack.onEntitySwing #1499

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

ApexModder
Copy link
Contributor

The InteractionHand is simply passed to ItemStack.onEntitySwing - Fixes #1497.

The original method is deprecated and scheduled for removal in version 21.2 (next breaking change window). The new method delegates to the original to avoid breaking existing mods.

@ApexModder ApexModder added the 1.21.1 Targeted at Minecraft 1.21.1 label Aug 29, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 29, 2024

  • Publish PR to GitHub Packages

Last commit published: 82ec505a42cb1b8c034a79e119cc5d4b9b63edad.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1499' // https://github.com/neoforged/NeoForge/pull/1499
        url 'https://prmaven.neoforged.net/NeoForge/pr1499'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1499.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1499
cd NeoForge-pr1499
curl -L https://prmaven.neoforged.net/NeoForge/pr1499/net/neoforged/neoforge/21.1.41-pr-1499-pr-entity-swing/mdk-pr1499.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@sciwhiz12 sciwhiz12 added the enhancement New (or improvement to existing) feature or request label Aug 29, 2024
Add missing annotation
@ApexModder
Copy link
Contributor Author

Ive looked through the other item extension methods and noticed 2 others which could be passed the interaction hand onStopUsing, doesSneakBypassUse.
What are peoples thoughts on patching these to also have the hand passed?

@ApexModder ApexModder merged commit 0303531 into neoforged:1.21.x Sep 5, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"IItemstackExtension#onEntitySwing" method should take "InteractionHand" as a parameter
3 participants