-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21.1] Pass along interaction had to ItemStack.onEntitySwing #1499
Conversation
Last commit published: 82ec505a42cb1b8c034a79e119cc5d4b9b63edad. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1499' // https://github.com/neoforged/NeoForge/pull/1499
url 'https://prmaven.neoforged.net/NeoForge/pr1499'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1499
cd NeoForge-pr1499
curl -L https://prmaven.neoforged.net/NeoForge/pr1499/net/neoforged/neoforge/21.1.41-pr-1499-pr-entity-swing/mdk-pr1499.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
src/main/java/net/neoforged/neoforge/common/extensions/IItemExtension.java
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/extensions/IItemStackExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/extensions/IItemExtension.java
Outdated
Show resolved
Hide resolved
Add missing annotation
Ive looked through the other item extension methods and noticed 2 others which could be passed the interaction hand |
🚀 This PR has been released as NeoForge version |
The
InteractionHand
is simply passed toItemStack.onEntitySwing
- Fixes #1497.The original method is deprecated and scheduled for removal in version
21.2
(next breaking change window). The new method delegates to the original to avoid breaking existing mods.