Allow setting if the critical hit should disable sweep attack in CriticalHitEvent
#1314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1313.
Introduce a
disableSweepAttack
field to theCriticalHitEvent
, equals toisVanillaCritical
by default, matching vanilla behavior.Now the sweep attack will only be disabled when
isCriticalHit()
anddisableSweepAttack()
both returnstrue
.This would change the behavior of existing subscriber of this event who set
isCriticalHit
totrue
, as now these modded critical would allow sweep attack when they are not vanilla critical. It's now up to these mod's decision to disable the sweep attack or not for their modded critical hit.