Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CRLF line endings in mod list's details #1481

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

Closes #1316

This is a temporary dirty workaround until Sci's entire rework of the mod list screen. Tested using the person's mods.toml setup with a neo test mod to verify the line endings are replaced

@TelepathicGrunt TelepathicGrunt added bug A bug or error 1.21.1 Targeted at Minecraft 1.21.1 labels Aug 23, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 23, 2024

  • Publish PR to GitHub Packages

Last commit published: 37a498dd7838f0e8bd5d8753e64463e5a18e35ab.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1481' // https://github.com/neoforged/NeoForge/pull/1481
        url 'https://prmaven.neoforged.net/NeoForge/pr1481'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1481.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1481
cd NeoForge-pr1481
curl -L https://prmaven.neoforged.net/NeoForge/pr1481/net/neoforged/neoforge/21.1.35-pr-1481-lineEndingModlist/mdk-pr1481.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@TelepathicGrunt TelepathicGrunt changed the title Replace CRLF line endings in mod details Replace CRLF line endings in mod list's details Aug 23, 2024
@sciwhiz12 sciwhiz12 self-requested a review August 25, 2024 03:10
Matyrobbrt
Matyrobbrt previously approved these changes Aug 27, 2024
Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by using multiline strings in fields other than the description (which is already normalized in FML), and it works.

@sciwhiz12 sciwhiz12 merged commit fc3efaa into neoforged:1.21.x Aug 27, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mod list renders special line ending characters
3 participants