-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace CRLF line endings in mod list's details #1481
Replace CRLF line endings in mod list's details #1481
Conversation
Last commit published: 37a498dd7838f0e8bd5d8753e64463e5a18e35ab. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1481' // https://github.com/neoforged/NeoForge/pull/1481
url 'https://prmaven.neoforged.net/NeoForge/pr1481'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1481
cd NeoForge-pr1481
curl -L https://prmaven.neoforged.net/NeoForge/pr1481/net/neoforged/neoforge/21.1.35-pr-1481-lineEndingModlist/mdk-pr1481.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
src/main/java/net/neoforged/neoforge/client/gui/ModListScreen.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by using multiline strings in fields other than the description (which is already normalized in FML), and it works.
🚀 This PR has been released as NeoForge version |
Closes #1316
This is a temporary dirty workaround until Sci's entire rework of the mod list screen. Tested using the person's mods.toml setup with a neo test mod to verify the line endings are replaced