-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace json-styled translations with string-value translations #1490
Conversation
|
To add context, after discussion in Discord prompted by me, we decided that it would be best for NeoForge's language files to only use string-values in its translations. This is primarily because Crowdin does not understand the extended syntax that some translation keys currently use, leading to problems such as Crowdin mistakenly allowing translators to translate the Mods are free to use the extended syntax (as it stands now or whatever it may be in the future) based on their own design decisions on how they will handle translations, but as far as NeoForge itself is concerned, our use of Crowdin necessarily locks us into using string values. (Unless we find a way to get Crowdin to understand the extended syntax, but that's unlikely in my opinion.) |
Other than my remaining suggested change, the PR looks fine to me. Once it's done, I'll merge it in short order. |
@qznfbnj, what are you referring to? |
|
Ah, that makes it more clear. @HenryLoenwind, could you please fix that minor issue as well? |
🚀 This PR has been released as NeoForge version |
Replaced the json-styled translations that were used by the configuration screen with pure text (vanilla format) versions.
Adapted the configuration screen to apply the formatting in code.
A number of keys had to be split for this to work.