Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace json-styled translations with string-value translations #1490

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

HenryLoenwind
Copy link
Contributor

Replaced the json-styled translations that were used by the configuration screen with pure text (vanilla format) versions.

Adapted the configuration screen to apply the formatting in code.

A number of keys had to be split for this to work.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@sciwhiz12
Copy link
Member

To add context, after discussion in Discord prompted by me, we decided that it would be best for NeoForge's language files to only use string-values in its translations.

This is primarily because Crowdin does not understand the extended syntax that some translation keys currently use, leading to problems such as Crowdin mistakenly allowing translators to translate the color field of components in the extended syntax.

Mods are free to use the extended syntax (as it stands now or whatever it may be in the future) based on their own design decisions on how they will handle translations, but as far as NeoForge itself is concerned, our use of Crowdin necessarily locks us into using string values. (Unless we find a way to get Crowdin to understand the extended syntax, but that's unlikely in my opinion.)

@sciwhiz12 sciwhiz12 added bug A bug or error 1.21.1 Targeted at Minecraft 1.21.1 labels Aug 26, 2024
@sciwhiz12 sciwhiz12 self-requested a review August 26, 2024 04:50
@sciwhiz12
Copy link
Member

Other than my remaining suggested change, the PR looks fine to me. Once it's done, I'll merge it in short order.

@qznfbnj
Copy link

qznfbnj commented Sep 2, 2024

Is this intended?
image

@sciwhiz12
Copy link
Member

Is this intended? -- snipped image --

@qznfbnj, what are you referring to?

@qznfbnj
Copy link

qznfbnj commented Sep 2, 2024

Is this intended? -- snipped image --

@qznfbnj, what are you referring to?

image

@sciwhiz12
Copy link
Member

Ah, that makes it more clear. @HenryLoenwind, could you please fix that minor issue as well?

@sciwhiz12 sciwhiz12 self-assigned this Sep 2, 2024
@sciwhiz12 sciwhiz12 changed the title Replaced json-styled translations Replace json-styled translations with string-value translations Sep 3, 2024
@sciwhiz12 sciwhiz12 merged commit 72d5ebf into neoforged:1.21.x Sep 3, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants